Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add month-year and year appearance to calcite date picker #3455

Closed
fendiaoxiaoshuazi opened this issue Nov 9, 2021 · 13 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Survey123 Issues logged by ArcGIS Survey123 team members. c-datepicker Issues that pertain to the calcite-date-picker component design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. i18n-l10n issues dealing with internationalization/localization p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.

Comments

@fendiaoxiaoshuazi
Copy link

fendiaoxiaoshuazi commented Nov 9, 2021

Description

Support month-year and year only appearance in the calcite date picker.

Here are the screenshots of the month-year and year only appearance in bootstrap date picker
image
image

Acceptance Criteria

Relevant Info

Blocked issues: #9167, #8624, #10291, #10243, #10490

Which Component

calcite-date-picker

Example Use Case

@fendiaoxiaoshuazi fendiaoxiaoshuazi added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Nov 9, 2021
@fendiaoxiaoshuazi
Copy link
Author

Hi calcite team, I am a PE of the Survey123 team, and we are currently working on replacing our date and time picker with the calcite date and time picker for better A11y and I18N support. The month/year and year only appearance is critical for us, so we cannot fulfill the replacement at this point.

Do you have a timeframe time for this enhancement to be implemented?

@geospatialem geospatialem added the design Issues that need design consultation prior to development. label Jun 29, 2022
@fendiaoxiaoshuazi
Copy link
Author

fendiaoxiaoshuazi commented Nov 14, 2022

Hi Calcite team, we have partially replaced our pervious Wijimo date/time picker with the Calcite date/time picker. Since Calcite does not support month year and year only appearances, we have to keep the Wijimo date picker to support these appearances.

Therefore, we need to load 2 different libs for the date/time question, and there are many month year and year only appearances I18N issues are impeded by the replacement work.

We are waiting for Calcite to support month year and year only appearances to proceed with the replacement work. Do you have a timeframe time for this enhancement to be implemented?

@annierm18 annierm18 added ArcGIS Survey123 Issues logged by ArcGIS Survey123 team members. p - high Issue should be addressed in the current milestone, impacts component or core functionality i18n-l10n issues dealing with internationalization/localization labels Nov 14, 2022
@fendiaoxiaoshuazi
Copy link
Author

Hi Calcite team, we need to upgrade node.js to the latest version as required by the Security team, and we probably have to drop the Wijimo lib which we currently use for month-year and year-only appearances.

Therefore, Calcite's month-year and year-only appearances support become the pre-requisite of our node upgrade. We plan to upgrade node.js and drop Wijimo in our UC Release. If possible could you please prioritize this issue, and address this issue before May?

@benelan
Copy link
Member

benelan commented Feb 17, 2023

Hi @fendiaoxiaoshuazi, sorry for the delay! I'll make sure to bring it up again during our next triage. It is definitely a valid use case and something we would like to implement. However it is unlikely to be done by May, since it would require design and i18n feedback before development can start.

Which Node version are you currently on? If you're on an Active or Maintenance LTS version, updating to the latest minor/patch version should be sufficient security-wise. That should give us more time until your current date components need to be replaced.

https://nodejs.org/en/blog/vulnerability/february-2023-security-releases/

We are also revamping some of our processes so we can better communicate our plans and progress. Our original triage was scaled down during the lead up to v1, but we are starting to work through the back-fill. Thanks for the patience everyone!

@yixi8524
Copy link

@benelan Thanks for your prompt reply. We are still in Node.js 14 & NPM6 env. We must plan the next release to upgrade our Env and libs. Not only Node.js also include NPM, Webpack, Angular Framework, etc. So this is a good time to refactor our lib. If we can retire the Wijimo ASAP, it can let us easy to control the i18n and the A11Y support. Give the same and better UX experience to our users.

@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Mar 20, 2023
@geospatialem geospatialem added this to the 2023 May Priorities milestone Mar 20, 2023
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Mar 20, 2023
@macandcheese macandcheese added the c-datepicker Issues that pertain to the calcite-date-picker component label Mar 31, 2023
@SkyeSeitz SkyeSeitz self-assigned this Apr 18, 2023
@SkyeSeitz
Copy link

Howdy folks! Can I get some eyes on this proposed design ? Looking for feedback before moving any further. Thanks!
@macandcheese @jcfranco
image

@anveshmekala
Copy link
Contributor

anveshmekala commented Jul 4, 2024

Attaching wiki notes for reference.

cc @jcfranco @geospatialem @SkyeSeitz

@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Aug 23, 2024
anveshmekala added a commit that referenced this issue Oct 23, 2024
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Oct 23, 2024
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Oct 25, 2024

The original ask of this issue has been broken off into these new issues:
#9394
#9393

And this issue was repurposed to add the following enhancements to date-picker:

Changes

  • display two calendars for range irrespective of layout.
  • No longer switches focus from day to end input when startDate is selected initially.
  • Month selection is possible via select menu
  • No longer positions the date-picker component relative to endInput when endInput is focused in range.
  • Dates from previous months are not visible in range calendar.
  • Divider indicator icons are removed in horizontal layout for range in input-date-picker.
  • No longer uses chevron icon which indicate the open status of input-date-picker in startInput field.

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Oct 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 25, 2024
@SkyeSeitz SkyeSeitz removed the ready for dev Issues ready for development implementation. label Jan 23, 2025
benelan pushed a commit that referenced this issue Feb 8, 2025
…#8402)

**Related Issue:** #3455, #10113 

## Summary

Update `calcite-date-picker` & `calcite-input-date-picker` UI & UX.



![4D1CFC3C-8FF9-4493-9178-4DEDA0417031](https://github.com/user-attachments/assets/4b1f5a12-85df-4577-b1cd-812c22e41ef7)

### Key changes
- display two calendars for range irrespective of layout.
- No longer switches focus from day to end input when startDate is
selected initially.
- Month selection is possible via select menu
- No longer positions the date-picker component relative to endInput
when endInput is focused in range.
- Dates from previous months are not visible in range calendar.
- Divider indicator icons are removed in horizontal layout for range in
input-date-picker.
- No longer uses chevron icon which indicate the open status of
input-date-picker in startInput field.


Other issues resolved :
#6321
#6410
#10301
#10291
#10113
#10243
#10490

Blocked issues: #9167 

Wiki
https://github.com/Esri/calcite-design-system/wiki/date%E2%80%90picker-enhancement-%238402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Survey123 Issues logged by ArcGIS Survey123 team members. c-datepicker Issues that pertain to the calcite-date-picker component design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 8 Requires input from team, consider smaller steps. i18n-l10n issues dealing with internationalization/localization p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Development

No branches or pull requests