[Ellipsis] fix: handle file size limits and encoding in _content_files_list
#189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses review comments left by @ErikBjare on PR #188: fix: limit image size, fixes exception when viewing large images (#185)
Summary:
Enhances
_content_files_list
inmessage.py
to handle file size limits and improve base64 encoding efficiency for OpenAI and Anthropic providers.Key points:
ValueError
in_content_files_list
if neitheropenai
noranthropic
is true._content_files_list
, appending a warning message if file exceeds 5MB.data
variable for base64 encoding in_content_files_list
to avoid redundant encoding._content_files_list
to improve readability and efficiency.You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Something look wrong? If this Pull Request doesn't address the comments left on the above pull request, create a new PR review with more details. For more information, check the documentation.
Generated with ❤️ by ellipsis.dev