fix: limit image size, fixes exception for large images (fixes #185) #188
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 9a4d2f6 in 21 seconds
More details
- Looked at
60lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_4pA8j01BQW1yowxI
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| # anthropic limit is 5MB | ||
| # TODO: use compression to reduce file size | ||
| # print(f"{len(data)=}") | ||
| if len(data) > 5_000_000: |
There was a problem hiding this comment.
Checking the size of data (base64 encoded) is incorrect for file size validation. Base64 encoding increases the size by approximately 33%. Instead, check len(data_bytes) to ensure the original file size is within limits.
There was a problem hiding this comment.
@ellipsis-dev I did that originally, but it didn't match the numbers returned by the API (roughly the 33% difference), maybe add a comment about this.
There was a problem hiding this comment.
@ErikBjare, I have addressed your comments in pull request #189
You can configure Ellipsis to address comments with a direct commit or a side PR, see docs.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 80.39% 80.78% +0.39%
==========================================
Files 56 56
Lines 3305 3315 +10
==========================================
+ Hits 2657 2678 +21
+ Misses 648 637 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…ixes exception when viewing large images (#185));
ErikBjare
changed the title
ErikBjare
changed the title
Important
Adds a 5MB image size limit and provider check in
_content_files_list()inmessage.pyto prevent exceptions with large images._content_files_list()inmessage.py. If exceeded, appends a warning message to content.ValueErrorif neitheropenainoranthropicis specified in_content_files_list().datavariable for reuse inmessage.py.This description was created by
for 9a4d2f6. It will automatically update as commits are pushed.