Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple NTRs, closes #1367 #1391

Merged
merged 4 commits into from
Aug 26, 2023
Merged

multiple NTRs, closes #1367 #1391

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e23c1
closes #1367 ?
turbomam Dec 5, 2022
9e97d65
Merge branch 'master' into issue-1367
turbomam Jun 29, 2023
c23427a
Merge branch 'master' into issue-1367
cmungall Aug 26, 2023
392f2ae
Merge branch 'master' into issue-1367
cmungall Aug 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions src/envo/envo-edit.owl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3984,6 +3984,10 @@ Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600084>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600085>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600086>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600087>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600090>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600091>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600092>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_03600093>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_04000000>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_04000001>))
Declaration(Class(<http://purl.obolibrary.org/obo/ENVO_04000002>))
Expand Down Expand Up @@ -44772,6 +44776,51 @@ AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#hasBroadSynony
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600087> "greenhouse"@en)
SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600087> <http://purl.obolibrary.org/obo/ENVO_00000070>)

# Class: <http://purl.obolibrary.org/obo/ENVO_03600090> (alcohol fermentation pit)

AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600090> "A fermentation pit which is constructed to facilitate the fermentation of alcoholic substances.")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600090> "https://orcid.org/0000-0001-9076-6066")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600090> "https://orcid.org/0000-0001-9625-1899")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600090> "https://orcid.org/0000-0002-4366-3088")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#creation_date> <http://purl.obolibrary.org/obo/ENVO_03600090> "2021-08-09T15:00:00.000Z")
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600090> "Definition from 2021-08-05 call with Buttigieg, Duncan and Miller")
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600090> "alcohol fermentation pit")
SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600090> <http://purl.obolibrary.org/obo/ENVO_03600039>)

# Class: <http://purl.obolibrary.org/obo/ENVO_03600091> (clay fermentation pit)

AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600091> "A fermentation pit which is constructed from clay.")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600091> "https://orcid.org/0000-0001-9076-6066")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600091> "https://orcid.org/0000-0001-9625-1899")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600091> "https://orcid.org/0000-0002-4366-3088")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#creation_date> <http://purl.obolibrary.org/obo/ENVO_03600091> "2021-08-09T15:00:00.000Z")
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600091> "Definition from 2021-08-05 call with Buttigieg, Duncan and Miller")
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600091> "clay fermentation pit")
SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600091> <http://purl.obolibrary.org/obo/ENVO_01001871>)
Comment on lines +44792 to +44799
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An axiom that links this to ENVO:clay would be handy, but not a necessity


# Class: <http://purl.obolibrary.org/obo/ENVO_03600092> (artificial pond)

AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600092> "A pond which has been constructed by humans or their technologies.")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600092> "https://orcid.org/0000-0001-9076-6066")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600092> "https://orcid.org/0000-0001-9625-1899")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600092> "https://orcid.org/0000-0002-4366-3088")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#creation_date> <http://purl.obolibrary.org/obo/ENVO_03600092> "2021-08-09T15:00:00.000Z")
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600092> "Definition from 2021-08-05 call with Buttigieg, Duncan and Miller")
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600092> "artificial pond")
SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600092> <http://purl.obolibrary.org/obo/ENVO_00000033>)
Comment on lines +44803 to +44810
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the axiom about being the output of a human-led construction process - that would allow it to be reasoned under the respective branch.


# Class: <http://purl.obolibrary.org/obo/ENVO_03600093> (artificial satellite)

AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Satellite") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600093> "A human construction that has intentionally been placed into orbit.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The placement may not always be artificial, but should be okay for now.

AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600093> "https://orcid.org/0000-0001-9076-6066")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600093> "https://orcid.org/0000-0001-9625-1899")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600093> "https://orcid.org/0000-0002-4366-3088")
AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#creation_date> <http://purl.obolibrary.org/obo/ENVO_03600093> "2021-08-09T15:00:00.000Z")
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600093> "Definition from 2021-08-05 call with Buttigieg, Duncan and Miller")
AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600093> "Not to be confused with a natural satellite like the earth's moon (https://en.wikipedia.org/wiki/Natural_satellite)")
AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600093> "artificial satellite")
SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600093> <http://purl.obolibrary.org/obo/ENVO_00000070>)

# Class: <http://purl.obolibrary.org/obo/ENVO_04000000> (adfreezing)

AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://www.merriam-webster.com/dictionary/adfreezing") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_04000000> "Adfreezing is a freezing process during which two objects adhere to each other via ice.")
Expand Down