multiple NTRs, closes #1367 #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbuttigieg
requested changes
Dec 5, 2022
|
|
||
| # Class: <http://purl.obolibrary.org/obo/ENVO_03600093> (artificial satellite) | ||
|
|
||
| AnnotationAssertion(Annotation(<http://www.geneontology.org/formats/oboInOwl#hasDbXref> "https://en.wikipedia.org/wiki/Satellite") <http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600093> "A human construction that has intentionally been placed into orbit.") |
There was a problem hiding this comment.
The placement may not always be artificial, but should be okay for now.
Comment on lines
+44803
to
+44810
| AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600092> "A pond which has been constructed by humans or their technologies.") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600092> "https://orcid.org/0000-0001-9076-6066") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600092> "https://orcid.org/0000-0001-9625-1899") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600092> "https://orcid.org/0000-0002-4366-3088") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#creation_date> <http://purl.obolibrary.org/obo/ENVO_03600092> "2021-08-09T15:00:00.000Z") | ||
| AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600092> "Definition from 2021-08-05 call with Buttigieg, Duncan and Miller") | ||
| AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600092> "artificial pond") | ||
| SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600092> <http://purl.obolibrary.org/obo/ENVO_00000033>) |
There was a problem hiding this comment.
I don't see the axiom about being the output of a human-led construction process - that would allow it to be reasoned under the respective branch.
Comment on lines
+44792
to
+44799
| AnnotationAssertion(<http://purl.obolibrary.org/obo/IAO_0000115> <http://purl.obolibrary.org/obo/ENVO_03600091> "A fermentation pit which is constructed from clay.") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600091> "https://orcid.org/0000-0001-9076-6066") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600091> "https://orcid.org/0000-0001-9625-1899") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#created_by> <http://purl.obolibrary.org/obo/ENVO_03600091> "https://orcid.org/0000-0002-4366-3088") | ||
| AnnotationAssertion(<http://www.geneontology.org/formats/oboInOwl#creation_date> <http://purl.obolibrary.org/obo/ENVO_03600091> "2021-08-09T15:00:00.000Z") | ||
| AnnotationAssertion(rdfs:comment <http://purl.obolibrary.org/obo/ENVO_03600091> "Definition from 2021-08-05 call with Buttigieg, Duncan and Miller") | ||
| AnnotationAssertion(rdfs:label <http://purl.obolibrary.org/obo/ENVO_03600091> "clay fermentation pit") | ||
| SubClassOf(<http://purl.obolibrary.org/obo/ENVO_03600091> <http://purl.obolibrary.org/obo/ENVO_01001871>) |
There was a problem hiding this comment.
An axiom that links this to ENVO:clay would be handy, but not a necessity
cmungall
approved these changes
Aug 26, 2023
cmungall
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1367
added the following from NMDC-03_EnvO_template_robot_sheet