Draft: refactor platforms, add windows support #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayconrod
force-pushed
the
jay-remote
branch
from
818e6b1 to
ae1466e
Compare
jayconrod
force-pushed
the
jay-remote
branch
from
ae1466e to
a35be8e
Compare
mbland
added a commit
that referenced
this pull request
Sep 9, 2024
Looks like 7.10.0 has problems on non-macOS platforms: - bazelbuild/rules_java: Regression with @@rules_java//toolchains:bootstrap_runtime_toolchain_type in 7.10.0 #214 bazelbuild/rules_java#214 - bazelbuild/rules_java: Rules java upgrade to 7.10.0 causes issues on Windows #218 bazelbuild/rules_java#218 The latter issue seems to match what we're seeing in CI: - https://github.com/EngFlow/example/actions/runs/10778667925/job/29890522476?pr=339 ```txt ERROR: no such package '@@rules_java~//tools/jdk': BUILD file not found in directory 'tools/jdk' of external repository @@rules_java~. Add a BUILD file to a directory to mark it as a package. ERROR: /home/engflow/.cache/bazel/_bazel_engflow/9a27675a6850b9fc7b6f4bb1996879a4/external/rules_java~~toolchains~local_jdk/BUILD.bazel:18:10: no such package '@@rules_java~//tools/jdk': BUILD file not found in directory 'tools/jdk' of external repository @@rules_java~. Add a BUILD file to a directory to mark it as a package. and referenced by '@@rules_java~~toolchains~local_jdk//:bootstrap_runtime_toolchain_definition' ``` Signed-off-by: Mike Bland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.