Skip to content

Commit

Permalink
Pull rules_java back to 7.9.1
Browse files Browse the repository at this point in the history
Looks like 7.10.0 has problems on non-macOS platforms:

- bazelbuild/rules_java: Regression with
  @@rules_java//toolchains:bootstrap_runtime_toolchain_type in 7.10.0
  #214
  bazelbuild/rules_java#214

- bazelbuild/rules_java: Rules java upgrade to 7.10.0 causes issues on
  Windows #218
  bazelbuild/rules_java#218

The latter issue seems to match what we're seeing in CI:

- https://github.com/EngFlow/example/actions/runs/10778667925/job/29890522476?pr=339

```txt
ERROR: no such package '@@rules_java~//tools/jdk': BUILD file not found
in directory 'tools/jdk' of external repository @@rules_java~. Add a
BUILD file to a directory to mark it as a package.

ERROR:
/home/engflow/.cache/bazel/_bazel_engflow/9a27675a6850b9fc7b6f4bb1996879a4/external/rules_java~~toolchains~local_jdk/BUILD.bazel:18:10:
no such package '@@rules_java~//tools/jdk': BUILD file not found in
directory 'tools/jdk' of external repository @@rules_java~. Add a BUILD
file to a directory to mark it as a package. and referenced by
'@@rules_java~~toolchains~local_jdk//:bootstrap_runtime_toolchain_definition'
```

Signed-off-by: Mike Bland <[email protected]>
  • Loading branch information
mbland committed Sep 9, 2024
1 parent 9880a3f commit e0b2818
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ go_deps.from_file(go_mod = "//:go.mod")

use_repo(go_deps, "com_github_google_go_cmp")

bazel_dep(name = "rules_java", version = "7.10.0")
bazel_dep(name = "rules_java", version = "7.9.1")

# https://github.com/bazelbuild/rules_jvm_external/blob/master/docs/bzlmod.md
bazel_dep(name = "rules_jvm_external", version = "6.2")
Expand Down
4 changes: 2 additions & 2 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e0b2818

Please sign in to comment.