Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

Remove: ChargeLinkV2Dto which was never fully implemented #1853

Merged
merged 6 commits into from
Nov 6, 2022

Conversation

prtandrup
Copy link
Contributor

Description

This PR removes the never used ChargeLinkV2Dto in both backend and in Charges.Client packages.
It was never fully implemented, and later abandoned.

References

  • #0000

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2022
@prtandrup prtandrup temporarily deployed to AzureAuth November 4, 2022 13:43 Inactive
@prtandrup prtandrup temporarily deployed to AzureAuth November 4, 2022 13:43 Inactive
@prtandrup prtandrup temporarily deployed to AzureAuth November 4, 2022 13:43 Inactive
@prtandrup prtandrup changed the title Remove: ChargeLinkV2Dto Remove: ChargeLinkV2Dto which was never fully implemented Nov 4, 2022
@prtandrup prtandrup marked this pull request as ready for review November 4, 2022 13:45
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #1853 (a315c74) into main (0ec3bd6) will decrease coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1853      +/-   ##
==========================================
- Coverage   84.69%   83.86%   -0.83%     
==========================================
  Files         470      447      -23     
  Lines        8165     7885     -280     
  Branches      433       22     -411     
==========================================
- Hits         6915     6613     -302     
+ Misses       1164     1151      -13     
- Partials       86      121      +35     
Flag Coverage Δ
business 87.67% <ø> (?)
clientlibraries 31.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s.QueryApi/ModelPredicates/ChargeLinkQueryLogic.cs 80.00% <ø> (-14.92%) ⬇️
...ergyHub.Charges.Domain/Charges/ChargeIdentifier.cs 0.00% <0.00%> (-100.00%) ⬇️
...ain/Dtos/Events/MarketParticipantCreatedCommand.cs 14.28% <0.00%> (-85.72%) ⬇️
...es.Domain/Dtos/Events/GridAreaOwnerAddedCommand.cs 33.33% <0.00%> (-66.67%) ⬇️
...Dtos/Events/MarketParticipantNameChangedCommand.cs 33.33% <0.00%> (-66.67%) ⬇️
...os/Events/MarketParticipantStatusChangedCommand.cs 33.33% <0.00%> (-66.67%) ⬇️
...vents/MarketParticipantB2CActorIdChangedCommand.cs 33.33% <0.00%> (-66.67%) ⬇️
....ApplyDBMigrationsApp/Helpers/EnvironmentFilter.cs 0.00% <0.00%> (-62.50%) ⬇️
....Domain/Dtos/Events/GridAreaOwnerRemovedCommand.cs 50.00% <0.00%> (-50.00%) ⬇️
...rastructure.Core/Registration/EnvironmentHelper.cs 0.00% <0.00%> (-50.00%) ⬇️
... and 69 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@prtandrup prtandrup temporarily deployed to AzureAuth November 4, 2022 14:00 Inactive
@prtandrup prtandrup temporarily deployed to AzureAuth November 4, 2022 14:00 Inactive
@prtandrup prtandrup temporarily deployed to AzureAuth November 4, 2022 14:00 Inactive
@HenrikSommer HenrikSommer temporarily deployed to AzureAuth November 4, 2022 14:21 Inactive
@HenrikSommer HenrikSommer temporarily deployed to AzureAuth November 4, 2022 14:21 Inactive
@HenrikSommer HenrikSommer temporarily deployed to AzureAuth November 4, 2022 14:21 Inactive
@HenrikSommer HenrikSommer temporarily deployed to AzureAuth November 4, 2022 14:21 Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prtandrup prtandrup merged commit 61d94db into main Nov 6, 2022
@prtandrup prtandrup deleted the pta/remove_ChargeLinksV2Dto branch November 6, 2022 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants