fix: unknown resolution in validation do not throw an exception (#1852)

* fixed resolution rule * removed reference
Energinet-DataHub · Nov 4, 2022 · 0ec3bd6 · 0ec3bd6
1 parent 8ab13cc
commit 0ec3bd6
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/...ation/InputValidation/ValidationRules/NumberOfPointsMatchTimeIntervalAndResolutionRule.cs b/...ation/InputValidation/ValidationRules/NumberOfPointsMatchTimeIntervalAndResolutionRule.cs
@@ -40,7 +40,7 @@ private void SetExpectedPointCount(Resolution resolution)
 
             _expectedPointCount = resolution switch
             {
-                Resolution.Unknown => throw new ArgumentException("Resolution may not be unknown"),
+                Resolution.Unknown => 0,
                 Resolution.PT15M => interval.Duration.TotalMinutes / 15,
                 Resolution.PT1H => interval.Duration.TotalHours,
                 Resolution.P1D => interval.Duration.TotalDays,

diff --git a/.../InputValidation/ValidationRules/NumberOfPointsMatchTimeIntervalAndResolutionRuleTests.cs b/.../InputValidation/ValidationRules/NumberOfPointsMatchTimeIntervalAndResolutionRuleTests.cs
@@ -13,9 +13,11 @@
 // limitations under the License.
 
 using System;
+using System.Collections.Generic;
 using Energinet.DataHub.Core.TestCommon.AutoFixture.Attributes;
 using FluentAssertions;
 using GreenEnergyHub.Charges.Domain.Charges;
+using GreenEnergyHub.Charges.Domain.Dtos.ChargePriceCommands;
 using GreenEnergyHub.Charges.Domain.Dtos.ChargePriceCommands.Validation.InputValidation.ValidationRules;
 using GreenEnergyHub.Charges.TestCore.Builders.Command;
 using NodaTime;
@@ -80,19 +82,28 @@ public void IsValid_WhenCalledWithCorrectNumberOfPrices_ShouldParse(
         }
 
         [Fact]
-        public void IsValid_WhenCalledWithUnknownPriceResolution_ShouldThrowArgumentException()
+        public void IsValid_WhenCalledWithUnknownPriceResolution_ShouldParse()
         {
             // Arrange
-            var dto = new ChargePriceOperationDtoBuilder().WithPriceResolution(Resolution.Unknown).Build();
+            var dto = new ChargePriceOperationDto(
+                "operationId",
+                ChargeType.Tariff,
+                "chargeId",
+                "owner",
+                Instant.MinValue,
+                Instant.MinValue,
+                Instant.MinValue,
+                Instant.MinValue,
+                Resolution.Unknown,
+                new List<Point>());
+
+            var sut = new NumberOfPointsMatchTimeIntervalAndResolutionRule(dto);
 
             // Act
-            Action act = () =>
-            {
-                _ = new NumberOfPointsMatchTimeIntervalAndResolutionRule(dto);
-            };
+            var actual = sut.IsValid;
 
             // Assert
-            act.Should().Throw<ArgumentException>();
+            actual.Should().BeTrue("To avoid throwing an exception, instead it parses with 0 points expected");
         }
 
         [Fact]