Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dialog): dialog closes on Esc down if disable-close-esc-keydown is enabled #979

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

dgonzalezr
Copy link
Collaborator

Description

Avoid the dialog to close when pressing the Esc key down if disable-close-esc-keydown is enabled.

Related Issue

Fixes #978

Documentation

Screenshots (if applicable)

CleanShot.2024-04-01.at.14.00.17.mp4

Checklist

  • I have read the CONTRIBUTING document.
  • I have read the CODE OF CONDUCT document.
  • I have reviewed my own code.
  • I have tested the changes locally.
  • I have updated the documentation (if applicable).
  • I have added unit tests and e2e tests (if applicable).
  • I have requested reviews from relevant team members.

Additional Notes

@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label Apr 1, 2024
Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@Cata1989 Cata1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgonzalezr dgonzalezr merged commit 721672d into main Apr 1, 2024
6 checks passed
@dgonzalezr dgonzalezr deleted the fix/dialog branch April 1, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Dialog closes when pressing Esc key even if disable-close-esc-keydown is enabled
2 participants