Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Dialog closes when pressing Esc key even if disable-close-esc-keydown is enabled #978

Closed
dgonzalezr opened this issue Apr 1, 2024 · 0 comments · Fixed by #979
Closed

Bug: Dialog closes when pressing Esc key even if disable-close-esc-keydown is enabled #978

dgonzalezr opened this issue Apr 1, 2024 · 0 comments · Fixed by #979
Assignees
@dgonzalezr
Labels
bug 🐛 Something isn't working

Comments

@dgonzalezr
Copy link
Collaborator

BEEQ package

beeq/core

BEEQ version

1.1.0

Current Behavior

When using the <bq-dialog> component and enabling the disableCloseEscKeydown, the dialog gets closed.

Expected Behavior

The dialog should not close if disableCloseEscKeydown is enabled.

<bq-dialog disable-close-esc-key-down> ... </bq-dialog>

Steps to Reproduce

  1. Go to Storybook: https://storybook.beeq.design/?path=/story/components-dialog--default
  2. Enable disable-close-esc-keydown in the Controls panel
  3. Press the Esc key
  4. The dialog will close when it shouldn't.

Code Reproduction URL

No response

Your Environment

No response

Additional Information

CleanShot.2024-04-01.at.13.55.53.mp4
@dgonzalezr dgonzalezr added the bug 🐛 Something isn't working label Apr 1, 2024
@dgonzalezr dgonzalezr self-assigned this Apr 1, 2024
@dgonzalezr dgonzalezr moved this to Backlog 📋 in BEEQ Design System Apr 1, 2024
@dgonzalezr dgonzalezr moved this from Backlog 📋 to Ready 👌 in BEEQ Design System Apr 1, 2024
@dgonzalezr dgonzalezr moved this from Ready 👌 to In progress 🛠️ in BEEQ Design System Apr 1, 2024
@dgonzalezr dgonzalezr mentioned this issue Apr 1, 2024
Merged
7 tasks
@dgonzalezr dgonzalezr moved this from In progress 🛠️ to Review 🔍 in BEEQ Design System Apr 1, 2024
@github-project-automation github-project-automation bot moved this from Review 🔍 to Done 🎉 in BEEQ Design System Apr 1, 2024
@dgonzalezr dgonzalezr moved this from Done 🎉 to Released 🚀 in BEEQ Design System Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgonzalezr dgonzalezr

Labels
bug 🐛 Something isn't working
Projects
BEEQ Design System
Status: Released 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Dialog): dialog closes on Esc down if disable-close-esc-keydown is enabled Endava/BEEQ
1 participant
@dgonzalezr