Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update readme serve spa fixes #2 #3

Merged
merged 8 commits into from
Dec 15, 2022
Merged

Fix/update readme serve spa fixes #2 #3

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa25f03
add test case negative and positive for `SPA` filepath.Abs err on win…
amustaque97 Jun 1, 2022
eee2166
fix comments wrap-lines and uncomment code
amustaque97 Jun 1, 2022
4a15a9b
fix condition of test case to check if not contain substring
amustaque97 Jun 1, 2022
e5c7656
fix `README.md` `Single Page Application` section to avoid err in win…
amustaque97 Jun 1, 2022
d086053
fix indentation `README.md`
amustaque97 Jun 1, 2022
36aa408
replace WriteFile package to fix test case for older go versions
amustaque97 Jun 1, 2022
d308dd3
remove err condtion after filepath.Join statement
amustaque97 Jun 3, 2022
a3df0f4
fix `path` var initialisation
amustaque97 Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,20 +251,11 @@ type spaHandler struct {
// file located at the index path on the SPA handler will be served. This
// is suitable behavior for serving an SPA (single page application).
func (h spaHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// get the absolute path to prevent directory traversal
path, err := filepath.Abs(r.URL.Path)
if err != nil {
// if we failed to get the absolute path respond with a 400 bad request
// and stop
http.Error(w, err.Error(), http.StatusBadRequest)
return
}

// prepend the path with the path to the static directory
path = filepath.Join(h.staticPath, path)
// Join internally call path.Clean to prevent directory traversal
path := filepath.Join(h.staticPath, path)

// check whether a file exists at the given path
_, err = os.Stat(path)
_, err := os.Stat(path)
if os.IsNotExist(err) {
// file does not exist, serve index.html
http.ServeFile(w, r, filepath.Join(h.staticPath, h.indexPath))
Expand Down