Fix/update readme serve spa fixes #2 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tebruno99
merged commit 60a3468
into
ElasticPerch:bugfix/2-question-gorillamux-spa-not-working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: gorilla#678
Fixes: gorilla#588
Fixes: #2
Summary of Changes
Add test case to validate proposed fix (both negative and positive test case).
Update README.md file.
PS: If you want to verify how I'm able to reproduce the issue and tried my fix. Here is a link of my local PR where I have configured Github Action to execute same test cases on all the platforms i.e. ubuntu, macos and windows.