fixed some technical terms in the readme #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,8 +17,8 @@ There are two recommended ways of running the project: | |||
|
|
|||
| ### Running with Docker | |||
| Using Docker has the advantage of starting everything up automatically, | |||
| including certificate generation, tests and linting, as well as creating | |||
| both the SECC and EVCC. | |||
| including certificate generation, tests and linting, as well as spawning | |||
There was a problem hiding this comment.
Either is fine in this context, I think -- @nikkigithub1 was there a specific reason to change "spawning" to "creating" in the first place?
sabrinagordon-believ
approved these changes
May 24, 2022
| @@ -192,21 +193,21 @@ The following table provides a few of the available variables: | |||
| | MESSAGE_LOG_EXI | `False` | Whether or not to log the EXI Bytestream messages (only works if log level is set to DEBUG) | |||
|
|
|||
|
|
|||
| ## Licence | |||
| ## License | |||
There was a problem hiding this comment.
I think this is fine -- American English is often the standard in a technical context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.