Feature/test data and fixes #276
Conversation
martinbachmanndesignwerk
force-pushed
the
feature/test_data_and_fixes
branch
from
8f9f8bd to
3c37f43
Compare
| await self.evse_controller.set_status_secc_session( | ||
| ServiceStatus.STARTING | ||
| ) |
There was a problem hiding this comment.
We currently use ServiceStatus to indicate starting and stopping of the entire iso15118_service in our pro version. I see the intention here is to indicate starting and stopping of charging sessions instead. Could you add a new enum SessionStatus along the lines of SESSION_STARTED, SESSION_ENDED for this, please?
There was a problem hiding this comment.
I've checked if this status is relevant in our code. But it is not. We can remove the whole function.
| @@ -315,6 +318,7 @@ async def end_current_session( | |||
| ) | |||
| await cancel_task(self.tcp_server_handler) | |||
| await cancel_task(self.comm_sessions[peer_ip_address][1]) | |||
| await self.evse_controller.set_status_secc_session(ServiceStatus.STOPPING) | |||
There was a problem hiding this comment.
Same comment as above - SessionStatus.SESSION_ENDED here?
| @@ -188,6 +195,13 @@ async def set_status(self, status: ServiceStatus) -> None: | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| @abstractmethod | |||
| async def set_status_secc_session(self, status: ServiceStatus) -> None: | |||
There was a problem hiding this comment.
The type here would also need updating to the new enum.
| async def set_status_secc_session(self, status: ServiceStatus) -> None: | ||
| pass | ||
|
|
There was a problem hiding this comment.
Same comment as above.
| There are EVs that sometimes send values below zero | ||
| (e.g. Skoda Enyaq). | ||
| """ | ||
|
|
||
| _min_limit: int = -10 | ||
| unit: Literal[UnitSymbol.AMPERE] = Field(None, alias="Unit") |
There was a problem hiding this comment.
Out of curiosity - when does this usually happen?
There was a problem hiding this comment.
This can happen when charging starts. I don't know why but some times they request a negative current as first current demand request.
… range definition)
(because Skoda Enyaq sends in the beginning of CurrentDemand a value of -2)
martinbachmanndesignwerk
force-pushed
the
feature/test_data_and_fixes
branch
from
a977800 to
eeb271c
Compare
|
@shalinnijel2 I've rebased everything and removed the |
This PR replaces #232
Everything is rebased and changes requested by @tropxy are implemented