Feature/some updates and fixes #232
Conversation
| logger.error( | ||
| f"EXI message (ns={self.get_exi_ns(v2gtp_msg.payload_type)}) " | ||
| f"where validation failed: {v2gtp_msg.payload.hex()}" | ||
| ) | ||
| return | ||
| except EXIDecodingError as exc: | ||
| logger.exception(f"{exc}") | ||
| logger.error( | ||
| f"EXI message (ns={self.get_exi_ns(v2gtp_msg.payload_type)}) " | ||
| f"where error occured: {v2gtp_msg.payload.hex()}" | ||
| ) |
There was a problem hiding this comment.
We have an env to enable the logging of the EXI messages:
https://github.com/SwitchEV/iso15118/blob/master/iso15118/shared/settings.py#L18
wouldnt that satisfy your needs?
There was a problem hiding this comment.
Those messages are just logged in case of an exception. This way it is possible to reproduce the situation in simulation.
| from dataclasses import dataclass | ||
|
|
||
|
|
||
| @dataclass | ||
| class ExiMessageContainer: | ||
| message_name: str | ||
| json_str: str | ||
| description: str = "" |
There was a problem hiding this comment.
I would vote on putting this in the messages/init.py or in the tests/conftest.py. What do you think @lukaslombriserdesignwerk @shalinnijel2 ?
lukaslombriserdesignwerk
force-pushed
the
feature/some_updates_and_fixes
branch
3 times, most recently
from
7224837 to
fd45149
Compare
|
Hi André cheers |
… range definition)
This reverts commit 85c89a4.
(because Skoda Enyaq sends in the beginning of CurrentDemand a value of -2)
lukaslombriserdesignwerk
force-pushed
the
feature/some_updates_and_fixes
branch
from
fd45149 to
19512cb
Compare
|
Hi André It would be great if you could make the review that it can be merged on the master branch. cheers |
|
Hi Lukas, I will take a look ;)
Best regards,
—
[image: signature_1470162048]
*André Duarte*
CTO at Switch <https://switch-ev.com/>
LinkedIn <https://www.linkedin.com/in/andrefilipef1/>
The Ministry, 79-81 Borough Road, London SE1 1DN
…On Tue, 6 Jun 2023 at 12:26, lukaslombriserdesignwerk < ***@***.***> wrote:
Hi André
It would be great if you could make the review that it can be merged on
the master branch.
Thank you very much!
cheers
—
Reply to this email directly, view it on GitHub
<#232 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7PVFTMFT5XZ7KW4BVU4PTXJ4HWPANCNFSM6AAAAAAXVZ7L4U>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
No description provided.