Support Python and Octave compliant model #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor config files
Fix configs and exe file
Removing matlab reading routines replaced by python
Co-authored-by: SarahAlidoost <[email protected]>
Co-authored-by: SarahAlidoost <[email protected]>
…E into octave-compliant
Modifications to make STEMMUS-SCOPE Octave compliant
Replace the codes of bash script with python codes
Co-authored-by: SarahAlidoost <[email protected]>
Merge `main` into `python-compliant`
SarahAlidoost
changed the title
|
@BSchilperoort I think this PR should fix some of the issues (see the lists above). Let me know if it is not correct. |
BSchilperoort
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Hi Sarah, I believe all those issues are fixed here, yes. I did not spot any issues with this PR, and we have been able to properly run python-compliant up to now, so I assume everything works correctly.
I did not see any other issues that will be closed by this PR.
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a description of the changes proposed in the pull request.
This PR merges the changes in the branch python-compliant, main changes are the use of PyStemmusScope package and Octave-compatible model source code.
Note: After merging, the empty column B in the sheet options in
input_data.xlsxfile should be removed on CRIB.closes #119
closes #118
closes #114
closes #110
closes #104
closes #63
closes #30
Update executable file
Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.
Checklist