-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifications to make STEMMUS-SCOPE Octave compliant #122
Conversation
src/STEMMUS_SCOPE_Octave.m
Outdated
@@ -0,0 +1,15 @@ | |||
% A function to run STEMMUS_SCOPE in Octave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's implement loading the packages in STEMMUS_SCOPE.m
as we discussed, see here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add loading packages to STEMMUS_SCOPE.m
in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I did not realize you wanted to do that in this PR. I have updated the code and tested it in Octave. Once I've verified it does not break Matlab I'll request your review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSchilperoort great job 👍 I left some suggestions. The instructions can be later improved and can be split for run and development purposes.
Co-authored-by: SarahAlidoost <[email protected]>
Co-authored-by: SarahAlidoost <[email protected]>
…E into octave-compliant
Thanks for the nice review @SarahAlidoost, you made it really easy with the ready-to-commit suggestions! 😄 |
Just one more thing, see my comment. :) |
The package loading is now performed in I could not build a new executable file, due to issues with the |
Great 👍
I will remove the file, re-create the exe file, and push it to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSchilperoort well done! great improvements.
Description
This PR will implement the changes required to make STEMMUS-SCOPE compliant with Octave. Functionally the model has not changed at all.
Note: the source
input_data.xlsx
file needs to have the empty columnB
in the sheetoptions
removed, for Octave compatibility.Closes #118 and #119
Update executable file
Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.
Checklist