Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update externals based on ESCOMP/CESM tag 'cesm3_0_beta02' #70

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

gdicker1
Copy link
Contributor

This PR combines changes to use externals based on those used in the cesm3_0_beta02 tag and to update the cime_config folder with CESM changes.

This PR is meant to be merged after #69

@gdicker1 gdicker1 added the upstream Related to the upstream repo (ESCOMP/CESM) label Aug 27, 2024
@gdicker1 gdicker1 self-assigned this Aug 27, 2024
@gdicker1 gdicker1 force-pushed the update/cesm3_0_beta02 branch 2 times, most recently from 9226271 to 6b051a0 Compare August 28, 2024 17:29
@gdicker1 gdicker1 force-pushed the update/cesm3_0_beta02 branch 2 times, most recently from aaea8b6 to 2272680 Compare August 30, 2024 00:10
Note that this change removes the mct coupler

This commit also rearranges the entries so they better match up with the
CESM/.gitmodules
NOTE: updating CAM also means compset definitions have changed;
'cam_dev' and 'CAM%DEV' no longer exist and are replaced with 'cam7' or
'CAM70' respectively.
Add testmods to turn off use_gw_front for EarthWorks compsets since
these tests still use ncdata without fields needed for frontogenesis.
@gdicker1 gdicker1 force-pushed the update/cesm3_0_beta02 branch from 2272680 to cbdc781 Compare August 30, 2024 00:21
@gdicker1 gdicker1 marked this pull request as ready for review August 30, 2024 17:53
@gdicker1
Copy link
Contributor Author

Testing the ew-pr category against runs of the same test category using the ew2.3.003 tag as baseline (results of #69) revealed:

  • QPC6 with nvhpc had NLCOMP and DIFF fails
  • CHAOS2000dev with nvhpc, intel, and gnu had NLCOMP and DIFF fails
  • F2000climoEW with nvhpc had NLCOMP and DIFF fails
  • FullyCoupledEW with nvhpc had NLCOMP and DIFF fails
  • FHS94 with nvhpc, intel, and gnu only had NLCOMP fail
  • FKESSLER with nvhpc only had NLCOMP fail

I think given the changes to the namelists and fields passed by the mediator (which is mentioned in the namelist comparison), the differences make sense. I think this PR is ready to go and will be merged later this afternoon.

(Also good news that CHAOS2000dev with GNU didn't report any problems.)

Copy link

@sherimickelson sherimickelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. I hit a runtime error with FHS94, but I think this is my doing. I was able to use flexi-mod okay and it looks like the clubb gpu code is there. The case built ok.

Use tags from merged Sub-PRs and update URLs in .gitmodules
@gdicker1 gdicker1 merged commit bad259b into EarthWorksOrg:develop Aug 30, 2024
@gdicker1 gdicker1 mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Related to the upstream repo (ESCOMP/CESM)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants