Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the institute facet of the CSIRO-Mk3L-1-2 model #1966

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Mar 10, 2023

Description

Changes institute from CSIRO-QCCCE to UNSW to make data from the CSIRO-Mk3L-1-2 model downloadable on ESGF.

Closes #1965

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@remi-kazeroni remi-kazeroni added the bug Something isn't working label Mar 10, 2023
@remi-kazeroni remi-kazeroni added this to the v2.8.0 milestone Mar 10, 2023
@remi-kazeroni remi-kazeroni self-assigned this Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1966 (bfa8619) into main (12a7551) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1966   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         236      236           
  Lines       12437    12437           
=======================================
  Hits        11525    11525           
  Misses        912      912           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@remi-kazeroni remi-kazeroni changed the title Fis the institute facet of the CSIRO-Mk3L-1-2 model Fix the institute facet of the CSIRO-Mk3L-1-2 model Mar 10, 2023
@bouweandela bouweandela changed the title Fix the institute facet of the CSIRO-Mk3L-1-2 model Update the institute facet of the CSIRO-Mk3L-1-2 model Mar 13, 2023
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The old institute name appears to have been used for older versions that are no longer available on ESGF.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @remi-kazeroni and @bouweandela - this is on her way to a merge now 🍺

@valeriupredoi valeriupredoi merged commit 576a5bb into main Mar 13, 2023
@valeriupredoi valeriupredoi deleted the fix_cmip5_institute_facet branch March 13, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing data for recipe_collins13ipcc.yml due to wrong institute facet
3 participants