Fixes for python3.8, and tweak travis-ci testing #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis-ci tests with python3 were failing with: ************* Module manic.repository_svn R1724:221,12: Unnecessary "else" after "continue" (no-else-continue) This should fix the problem. (I'm not sure why this started failing now: this is old code. Maybe pylint recently was updated to add this check?)
This is failing. It's using python2, which is no longer supported (though I don't know if that's why it's failing). I don't see the point in trying to update it to use python3, since I feel we have sufficient coverage with our linux testing, so for now I'm just removing it.
Trying to update the dictionary in-place in the loop leads to an error
in python 3.8 ("dictionary keys changed during iteration"). Instead,
create a copy of the dictionary, modified as needed.
Resolves ESMCI#135
|
@fischer-ncar once this is merged, we'll want to get it into a CESM tag ASAP, including on the release branch: Currently, |
1 similar comment
jedwards4b
approved these changes
Mar 2, 2020
|
@jedwards4b - Can I merge this to master? |
|
sure
…On Tue, Mar 3, 2020 at 9:31 AM Bill Sacks ***@***.***> wrote:
@jedwards4b <https://github.com/jedwards4b> - Can I merge this to master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#138?email_source=notifications&email_token=ABOXUGEUWDFYQUKEQ5OXGMLRFUWEVA5CNFSM4K76BYXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENUFXMY#issuecomment-594041779>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOXUGB6JOLUCEERDONKT6TRFUWEVANCNFSM4K76BYXA>
.
--
Jim Edwards
CESM Software Engineer
National Center for Atmospheric Research
Boulder, CO
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failing)
User interface changes?: No
Fixes ESMCI/cime#135 ("dictionary keys changed during iteration" when
running checkout_externals)
Testing: 'make lint', 'make test'
test removed: travis-ci testing on Mac OS
unit tests: pass
system tests: pass
manual testing:
With these diffs in a CESM checkout:
ensured that
manage_externals -Sgives the exact same output now asbefore.