Jedwards/check input issues #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
force-pushed
the
jedwards/check_input_issues
branch
from
b8d2258 to
a72a978
Compare
jedwards4b
force-pushed
the
jedwards/check_input_issues
branch
from
a72a978 to
162cee3
Compare
|
Thanks for fixing those mistakes. |
billsacks
added a commit
to ESMCI/manage_externals
that referenced
this pull request
Mar 3, 2020
Fixes for python3.8, and tweak travis-ci testing - Critical fix needed for python3.8 - pylint fix needed for all versions of python 3 - Add python3.7 and python3.8 testing through travis-ci - Remove travis-ci testing on Mac OS (which was using python2, and was failing) User interface changes?: No Fixes ESMCI/cime#135 ("dictionary keys changed during iteration" when running checkout_externals) Testing: 'make lint', 'make test' test removed: travis-ci testing on Mac OS unit tests: pass system tests: pass manual testing: With these diffs in a CESM checkout: ```diff diff --git a/Externals.cfg b/Externals.cfg index b943c25..6b0f03e 100644 --- a/Externals.cfg +++ b/Externals.cfg @@ -39,7 +39,7 @@ required = True tag = release-cesm2.0.03 protocol = git repo_url = https://github.com/ESCOMP/mosart -local_path = components/mosart +local_path = ./components/mosart required = True [pop] ``` ensured that `manage_externals -S` gives the exact same output now as before.
kettleofmonkeys
pushed a commit
to adamrher/CAM
that referenced
this pull request
Oct 31, 2023
Fixes for python3.8, and tweak travis-ci testing - Critical fix needed for python3.8 - pylint fix needed for all versions of python 3 - Add python3.7 and python3.8 testing through travis-ci - Remove travis-ci testing on Mac OS (which was using python2, and was failing) User interface changes?: No Fixes ESMCI/cime#135 ("dictionary keys changed during iteration" when running checkout_externals) Testing: 'make lint', 'make test' test removed: travis-ci testing on Mac OS unit tests: pass system tests: pass manual testing: With these diffs in a CESM checkout: ```diff diff --git a/Externals.cfg b/Externals.cfg index b943c25..6b0f03e 100644 --- a/Externals.cfg +++ b/Externals.cfg @@ -39,7 +39,7 @@ required = True tag = release-cesm2.0.03 protocol = git repo_url = https://github.com/ESCOMP/mosart -local_path = components/mosart +local_path = ./components/mosart required = True [pop] ``` ensured that `manage_externals -S` gives the exact same output now as before.
kettleofmonkeys
pushed a commit
to adamrher/CAM
that referenced
this pull request
Oct 31, 2023
Fixes for python3.8, and tweak travis-ci testing - Critical fix needed for python3.8 - pylint fix needed for all versions of python 3 - Add python3.7 and python3.8 testing through travis-ci - Remove travis-ci testing on Mac OS (which was using python2, and was failing) User interface changes?: No Fixes ESMCI/cime#135 ("dictionary keys changed during iteration" when running checkout_externals) Testing: 'make lint', 'make test' test removed: travis-ci testing on Mac OS unit tests: pass system tests: pass manual testing: With these diffs in a CESM checkout: ```diff diff --git a/Externals.cfg b/Externals.cfg index b943c25..6b0f03e 100644 --- a/Externals.cfg +++ b/Externals.cfg @@ -39,7 +39,7 @@ required = True tag = release-cesm2.0.03 protocol = git repo_url = https://github.com/ESCOMP/mosart -local_path = components/mosart +local_path = ./components/mosart required = True [pop] ``` ensured that `manage_externals -S` gives the exact same output now as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #132, this fixes some issues with check_input_data.