improved logging facility #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| logging.basicConfig() | ||
| # set up logging to file | ||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
Doesn't this turn on --verbose always?
There was a problem hiding this comment.
I moved some stuff that we had set to info into debug, the idea being that we want the default output level to be more informational than warn.
There was a problem hiding this comment.
OK, so logging.info(...) is something users will always see?
There was a problem hiding this comment.
By default, yes. --silent turns it off.
1) Remove newlines from logger.info statements, it already adds them 2) Change test_name to a debug, it was adding too much clutter 3) Change run_cmd to support verbose flag properly
|
Closed, made new PR. |
Minor changes:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging facility now includes a -s, --silent option.
When a script is run at the --debug level it also creates a file scriptname.log
So there are now 4 levels of logging:
default (no option)
--silent
--verbose
--debug