Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes: #2

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Minor changes: #2

merged 1 commit into from
Mar 3, 2016

Conversation

jgfouca
Copy link

@jgfouca jgfouca commented Mar 3, 2016

  1. Remove newlines from logger.info statements, it already adds them
  2. Change test_name to a debug, it was adding too much clutter
  3. Change run_cmd to support verbose flag properly

@jgfouca
Minor changes:
c62435e 
1) Remove newlines from logger.info statements, it already adds them
2) Change test_name to a debug, it was adding too much clutter
3) Change run_cmd to support verbose flag properly
jedwards4b added a commit that referenced this pull request Mar 3, 2016
@jedwards4b
Merge pull request #2 from ESMCI/logging_facility_improvement
4fe90c5 
Minor changes:
@jedwards4b jedwards4b merged commit 4fe90c5 into jedwards4b:logging_facility_improvement Mar 3, 2016
@jgfouca jgfouca deleted the logging_facility_improvement branch March 8, 2016 21:07
jedwards4b pushed a commit that referenced this pull request Aug 18, 2016
@billsacks
Implementation #2 of running other unit tests from scripts_regression…
fdfa1a5 
…_tests

Test suite: None
Test baseline: N/A
Test namelist changes: N/A
Test status: N/A

Fixes: None

User interface changes?: No

Code review: None
jedwards4b pushed a commit that referenced this pull request Aug 18, 2016
@billsacks
Revert "Implementation #3 of running other unit tests from scripts_re…
9bea831 
…gression_tests"

This reverts commit b33215c.

I think that implementation #2 is probably the best: calling python -m unittest
discover from within a single unit test in scripts_regression_tests
jedwards4b pushed a commit that referenced this pull request Aug 18, 2016
@billsacks
Revert "Implementation #2 of running other unit tests from scripts_re…
84c01b0 
…gression_tests"

This reverts commit fdfa1a5.

This goes back to using the API to python's unittest module rather than spawning
a separate process (creating a test suite then a test runner, then calling 'run'
on the test runner)
jedwards4b pushed a commit that referenced this pull request May 8, 2017
@jgfouca
Merge branch 'jgfouca/alternative_impl_for_ers' (PR ESMCI#1482)
b661f5b 
Merge #2 for this PR.

* jgfouca/alternative_impl_for_ers:
  Fix bug
jedwards4b pushed a commit that referenced this pull request Apr 11, 2018
@apcraig
Merge pull request #2 from apcraig/mvertens/nuopcB_datamodels
f0f6bf5 
refactor of data models, stub models and dead models
jedwards4b pushed a commit that referenced this pull request Oct 9, 2018
@kdraeder
Merge pull request #2 from ESMCI/maint-5.6
4be92b8 
Maint 5.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgfouca @jedwards4b