Add NLDAS grid for CTSM and MOSART #3063

billsacks · 2019-04-04T12:36:09Z

Adds a high-resolution regional grid over the U.S. for use in land-only
simulations.

(I haven't added the necessary files to the inputdata repository yet,
but will do so once this and the corresponding CTSM PRs are accepted.)

Test suite: SMS test using this new grid in the context of a CTSM branch
with the necessary changes
Test baseline: n/a
Test namelist changes: none
Test status: bit for bit

Fixes none

User interface changes?: N

Update gh-pages html (Y/N)?: N

Code review:

It would be hard for someone to remember the right number of grid points to use; this new alias is easier to remember.

billsacks · 2019-04-04T12:38:43Z

config/cesm/config_grids.xml

@@ -120,6 +120,15 @@
      <grid name="rof">null</grid>
    </model_grid>

+    <!-- Regional NLDAS grid over the U.S. (roughly 12km resolution), with the standard NLDAS mask -->
+    <model_grid alias="nldas_mnldas" compset="DATM.+CLM">


Does this seem like a reasonable name for the alias? I struggled a bit, because the mask has the same name as the grid: we're using the standard NLDAS mask with the NLDAS grid.

For many grid aliases, we also give the ocean resolution, but that seems irrelevant here, and would lead to even more redundancy in the name (nldas_nldas_mnldas).

But I'm very open to suggestions here to keep this consistent with any grid naming conventions.

why nldas instead of 12km or nl12?

Good idea, @jedwards4b . Though a couple of thoughts on this are:

I prefer spelling things out a bit more, so would probably go with nldas12_mnldas or nldas12km_mnldas

Do you think that including 12 or 12km in the name gives the impression that the grid is at exactly 12 km (which isn't true)? This grid is actually at 1/8 deg – so roughly, but not exactly, 12 km.

@barlage I'd also welcome any opinions you have on this.

@billsacks My preference would be to keep this as nldas_mnldas and leave the details in the grid definition below; NLDAS is a well-defined grid but another consideration would be to add an NLDAS version here (e.g. nldas2) since I believe NLDAS v3 may have a different, higher resolution grid when released. Is there any need to explicitly declare this as regional in the model_grid?

billsacks · 2019-04-04T12:39:12Z

config/cesm/config_grids.xml

+      <grid name="atm">224x464_nldas</grid>
+      <grid name="lnd">224x464_nldas</grid>
+      <grid name="ocnice">224x464_nldas</grid>
+      <grid name="rof">null</grid>


I'm using the same mechanism we have used elsewhere to turn off ROF for this regional grid: setting the rof grid to null.

jedwards4b · 2019-04-04T13:04:42Z

config/cesm/config_grids.xml

@@ -120,6 +120,15 @@
      <grid name="rof">null</grid>
    </model_grid>

+    <!-- Regional NLDAS grid over the U.S. (roughly 12km resolution), with the standard NLDAS mask -->
+    <model_grid alias="nldas_mnldas" compset="DATM.+CLM">


why nldas instead of 12km or nl12?

barlage · 2019-04-04T15:21:07Z

config/cesm/config_grids.xml

@@ -120,6 +120,15 @@
      <grid name="rof">null</grid>
    </model_grid>

+    <!-- Regional NLDAS grid over the U.S. (roughly 12km resolution), with the standard NLDAS mask -->


Suggestion:

Regional NLDAS-2 grid over the U.S. (0.125 degree resolution; 25-53N, 235-293E), with the standard NLDAS-2 mask

barlage · 2019-04-04T15:25:10Z

config/cesm/config_grids.xml

@@ -120,6 +120,15 @@
      <grid name="rof">null</grid>
    </model_grid>

+    <!-- Regional NLDAS grid over the U.S. (roughly 12km resolution), with the standard NLDAS mask -->
+    <model_grid alias="nldas_mnldas" compset="DATM.+CLM">
+      <grid name="atm">224x464_nldas</grid>


is it too much to add the resolution here, e.g., 224x464_0.125_nldas2?

billsacks · 2019-04-04T21:16:24Z

Based on comments today, I need to rework this. I'll comment when it's ready for review.

Based on discussion in Thursday's CTSM software meeting

billsacks · 2019-04-08T16:42:33Z

I have updated this PR with new grid and mask names based on discussions with @barlage and @mvertens . I plan to make files using this new naming convention later today, so please speak up soon if you have problems with these names.

After that, I'll still need to:

Make new domain files using the new mask definition that we discussed on Thursday (using the mask of the NLDAS atmospheric forcing data, so it will include lakes)
Add grid and mapping files for a corresponding 1/8 deg regional ROF grid

These: - Use a land mask based on the nldas2 atmospheric forcing data, covering more points than we had been using before (this mask includes lakes and some additional coastal points) - Use the new grid name

Since the rof grid is identical to lnd, we should be able to use idmap for the rof <-> lnd mappings.

billsacks · 2019-04-16T15:22:26Z

Okay, this is ready for final review. @mvertens @jedwards4b @barlage do you want to look at this one last time, with particular focus on the grid names (full grid name and alias)?

Note that the ROF grid is identical to the LND grid, so no mapping files are needed.

billsacks · 2019-04-16T16:55:15Z

@mvertens gave her approval by email.

billsacks added 3 commits April 4, 2019 06:27

Add support for 224x464 NLDAS regional grid

f15032a

Remove number of grid points from nldas grid alias

e81e634

It would be hard for someone to remember the right number of grid points to use; this new alias is easier to remember.

Edit comments

38a447c

billsacks added ty: enhancement Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM tp: config labels Apr 4, 2019

billsacks self-assigned this Apr 4, 2019

billsacks requested a review from mvertens April 4, 2019 12:36

billsacks commented Apr 4, 2019

View reviewed changes

jedwards4b approved these changes Apr 4, 2019

View reviewed changes

barlage reviewed Apr 4, 2019

View reviewed changes

billsacks changed the title ~~Add NLDAS grid for CTSM~~ DO NOT MERGE: Add NLDAS grid for CTSM Apr 4, 2019

billsacks removed the request for review from mvertens April 4, 2019 21:16

Update nldas grid and mask names

81ee26c

Based on discussion in Thursday's CTSM software meeting

billsacks added 2 commits April 8, 2019 15:01

Update nldas mask info

753236e

Point to updated domain files for nldas2 grid

632ff00

These: - Use a land mask based on the nldas2 atmospheric forcing data, covering more points than we had been using before (this mask includes lakes and some additional coastal points) - Use the new grid name

billsacks mentioned this pull request Apr 14, 2019

Nldas grid ESCOMP/CTSM#682

Merged

Also use 0.125nldas2 grid for rof

4664dd4

Since the rof grid is identical to lnd, we should be able to use idmap for the rof <-> lnd mappings.

billsacks changed the title ~~DO NOT MERGE: Add NLDAS grid for CTSM~~ Add NLDAS grid for CTSM and MOSART Apr 16, 2019

billsacks requested a review from mvertens April 16, 2019 15:21

billsacks assigned jedwards4b and unassigned billsacks Apr 16, 2019

billsacks removed the request for review from mvertens April 16, 2019 16:53

jedwards4b merged commit a356310 into ESMCI:master Apr 16, 2019

billsacks deleted the nldas_grid_v2 branch April 16, 2019 19:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NLDAS grid for CTSM and MOSART #3063

Add NLDAS grid for CTSM and MOSART #3063

billsacks commented Apr 4, 2019

billsacks Apr 4, 2019

jedwards4b Apr 4, 2019

billsacks Apr 4, 2019

barlage Apr 4, 2019

billsacks Apr 4, 2019

jedwards4b Apr 4, 2019

barlage Apr 4, 2019 •

edited

Loading

barlage Apr 4, 2019

billsacks commented Apr 4, 2019

billsacks commented Apr 8, 2019

billsacks commented Apr 16, 2019

billsacks commented Apr 16, 2019

Add NLDAS grid for CTSM and MOSART #3063

Add NLDAS grid for CTSM and MOSART #3063

Conversation

billsacks commented Apr 4, 2019

billsacks Apr 4, 2019

Choose a reason for hiding this comment

jedwards4b Apr 4, 2019

Choose a reason for hiding this comment

billsacks Apr 4, 2019

Choose a reason for hiding this comment

barlage Apr 4, 2019

Choose a reason for hiding this comment

billsacks Apr 4, 2019

Choose a reason for hiding this comment

jedwards4b Apr 4, 2019

Choose a reason for hiding this comment

barlage Apr 4, 2019 • edited Loading

Choose a reason for hiding this comment

barlage Apr 4, 2019

Choose a reason for hiding this comment

billsacks commented Apr 4, 2019

billsacks commented Apr 8, 2019

billsacks commented Apr 16, 2019

billsacks commented Apr 16, 2019

barlage Apr 4, 2019 •

edited

Loading