Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nldas grid #682

Merged
merged 29 commits into from
May 1, 2019
Merged

Nldas grid #682

merged 29 commits into from
May 1, 2019

Conversation

billsacks
Copy link
Member

Description of changes

Add support for NLDAS grid

Specific notes

Contributors other than yourself, if any: @barlage helped with some file creation

CTSM Issues Fixed (include github issue #): none

Are answers expected to change (and if so in what way)? no

Any User Interface Changes (namelist or namelist defaults changes)? none

Testing performed, if any:
SMS_D.nldas2_mnldas2.I2000Clm50SpGs.cheyenne_intel.clm-default

Define the scrip grid file for the new nldas grid, and add the nldas
grid and associated mask as valid options.
ESMF version 7.0.0 has a bug that is fixed in 7.1.0r.

Fixes ESCOMP#642
Using 224x464_nldas for greater consistency with other grids: we
typically either give the number of grid cells or the resolution in the
name of the grid. I chose number of grid cells for consistency with our
other regional grid (5x5_amazon).
Currently, with a python2 pylint on cheyenne

   pylint 1.9.4,
   astroid 1.6.5
   Python 2.7.15 (default, Jan 11 2019, 15:22:07)

I get these pylint errors:

************* Module ctsm.joblauncher.job_launcher_no_batch
E: 49, 0: Bad option value 'subprocess-popen-preexec-fn' (bad-option-value)
C: 63, 4: Method name "wait_for_last_process_to_complete" doesn't conform to snake_case naming style (invalid-name)
gen_maps.sh is now gen_cesm_maps.sh, in a new location
- Updates cime to point to a version with support for this grid

- Adds PE layouts for this grid
Uses a shorter alias for the nldas grid
Using 0.125nldas2 rather than 224x464_nldas
These use the new name for the nldas grid, but otherwise should be the
same as before.
It appears that hirespft will require year 2005.

Also add a note that this won't work until the hirespft bug is fixed.
This is needed for hirespft
When we switch to hirespft, we'll be using year-2005. So it seems best
to start out consistent with that.
@billsacks
Copy link
Member Author

@ekluzek - I plan to bring this to master combined with the NWP configuration (i.e., combining them into a single branch and making a tag from that). And before I bring this to master, I'll make tags of cime and mosart. So this isn't quite in its final form. But I think all of the necessary CTSM changes for the NLDAS grid are now in place, so I wanted to give you a chance to give this a quick look, if you want.

@billsacks
Copy link
Member Author

cime changes are documented in ESMCI/cime#3063 (Note that that uses a rebased version of the cime branch, but the changes are the same as the ones included here.)

@billsacks
Copy link
Member Author

billsacks commented Apr 16, 2019

@ekluzek per your request, I have run mkmapdata.sh with a global and regional grid:

For global:

cmdargs="-r 10x15 -f /glade/p/cesmdata/cseg/inputdata/lnd/clm2/mappingdata/grids/SCRIPgrid_10x15_nomask_c110308.nc -t global"
regrid_num_proc=8
echo "args: $cmdargs"
echo "time env REGRID_PROC=$regrid_num_proc ./mkmapdata.sh $cmdargs\n"
time env REGRID_PROC=$regrid_num_proc ./mkmapdata_test.sh $cmdargs

For single point:

cmdargs="-r 1x1_brazil -f /glade/p/cesmdata/cseg/inputdata/lnd/clm2/mappingdata/grids/SCRIPgrid_1x1pt_brazil_nomask_c110308.nc -t regional"
regrid_num_proc=1
echo "args: $cmdargs"
echo "time env REGRID_PROC=$regrid_num_proc ./mkmapdata.sh $cmdargs\n"
time env REGRID_PROC=$regrid_num_proc ./mkmapdata_test.sh $cmdargs

In both cases, I changed mkmapdata's grid list to just contain one grid:

    grids=(                    \
           "0.5x0.5_AVHRR"     \
          )

Both completed successfully.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this all looks good. Before coming to master, I'd like to see the external hashes changed to tags, and the input files all checked into inputdata (I checked the SCRIPgrid file and it wasn't, but didn't check others).

@ekluzek ekluzek added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete and removed PR status: work in progress labels Apr 16, 2019
@billsacks
Copy link
Member Author

I think this all looks good. Before coming to master, I'd like to see the external hashes changed to tags, and the input files all checked into inputdata (I checked the SCRIPgrid file and it wasn't, but didn't check others).

Yup, working on both of those things now. (I wanted to wait for review approval before adding the files to the inputdata repo.)

These tags are the same as the hashes we were pointing to before.

For mosart: note that mosart1_0_31 is identical to release-cesm2.0.00
(we were originally pointing to that release tag on CTSM master).
This brings in the following already-tagged cime commits:

* 3a316af94 (tag: ctsm/ctsm1.0/cime5.7.9/n04) - (5 days ago) Generalize DATM_CLMNCEP_YR_ALIGN for present-day compsets - Bill Sacks
* 54bb3b59d - (5 days ago) Change DATM_CLMNCEP_YR_ALIGN for present-day compsets - Bill Sacks
* f9ac23663 (tag: ctsm/ctsm1.0/cime5.7.9/n03) - (12 days ago) Allow specific tests to ignore field list differences - Bill Sacks

In addition, this adds support for nldas datm forcing data.
@billsacks billsacks merged commit bb15795 into ESCOMP:master May 1, 2019
@billsacks billsacks deleted the nldas_grid branch May 1, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants