fates patch count controls #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
… file for testing
…h Erik we will have a different approach.
…P with MEGAN, and add tests for the FATES-SP version to aux_clm
ekluzek
requested changes
Jun 10, 2022
ekluzek
reviewed
Jun 10, 2022
|
@rgknox and I met to go over this, and did some good work to figure this out. Steps forward that we see will be to bring in the PR I added to this PR, and Ryan is also going to work with maxveg and natpft_ub a bit. In the longer term I want to refactor the surfrd part of this, but we'll have me do that part of this. |
|
We built a table to show how this works for different FATES modes... https://docs.google.com/spreadsheets/d/1OJ0eaNVb1AvDOnflrsY_haMoGZR6E4NGE1fMTkxl56c |
Conflicts: src/main/clm_initializeMod.F90
…meaning with fates versus non-fates
…dd a commented out line about what the expected correct line should be
|
OK, I think this is nearly ready. Things left to do that I see are to merge my dry-dep changes in, and then rerun testing. After that we can merge the FATES changes in, and then do the normal things to turn this into the next CTSM tag ctsm5.1.dev099. |
Fates drydep changes
ekluzek
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR is an API change. Primarily it allows fates to dictate the total number of naturally vegetated patches. If fates is in SP mode, it also ensures that CLM tracks enough patches to accomodate the LAI and height vectors that it needs to pass back. These modifications should move us closer (if not all the way there) to run CFTs as FATES patches as well.
Specific notes
Coupled with FATES PR: 862
Contributors other than yourself, if any:
@ekluzek fates-software-team
CTSM Issues Fixed (include github issue #):
Fixes #1764
Fixes #1762
Fixes #1784
Are answers expected to change (and if so in what way)? No bit-for-bit
Any User Interface Changes (namelist or namelist defaults changes)? New namelist item for fates
use_fates_tree_damage
Some new FATES damage dimensions
Testing performed, if any: regular and fates tests