replace constant leaf mass per area (lma) #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekluzek
added
tag: enh - new science
enhancement
ekluzek
approved these changes
Jan 15, 2021
ekluzek
changed the title
Add heat stored in biomass (for trees and shrubs) to the surface energy balance calculation. Add a switch for it and turn it on by default for clm5_1 physics. It's turned off for clm4_5, clm5_0 physics and when FATES is turned on. Those cases are identical to before, answers only change when it's turned on. Papers describing BHS simulations: R. Meier, Davin, E., Swenson, S., Lawrence, D., and Schwaab, Jo. (2019). Biomass heat storage dampens diurnal temperature variations in forests. Environmental Research Letters. 14. 084026. 10.1088/1748-9326/ab2b4e. S.C. Swenson, Burns, S. P., and Lawrence, D. M. ( 2019). The impact of biomass heat storage on the canopy energy balance and atmospheric stability in the community land model, Journal of Advances in Modeling Earth Systems, 11, 83– 98. https://doi.org/10.1029/2018MS001476
|
Since this updates param files let's fix #1184 as well. |
|
Also fix #478 |
… into heat_storage_biomass_merge
…when spinup_state, having it only set in Restart was the problem
This brings fates_main_api into and up-to-date with ctsm master. At the point of merge, fates_main_api was parallel with ctsm5.1.dev020, only one tag behind ctsm master's head. The purpose of this merge is to make all future updates to fates on the ctsm master branch instead of on the fates_main_api branch.
…s well, finishing it off
…age as it's moved to the Summary routine (note also for validation I checked that answers stay the same for these variables if I use the previous version of HydrologyNoDrainage and comment out the sums in Summary and it does).
… use a created surface dataset with this version partial fix for ESCOMP#1252
…ading the desired modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace hard code constant 0.25 for leaf mass per area with calculation based on parameter slatop (specific leaf area, top of canopy). Also move num_iter into loop over patches; currently it sits outside a loop, so p index is incorrect.
Also do some small answer changes in terms of new parameter files, and some other existing issues that have mild answer changes.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #1256
Fixes #1268
Fixes #1262
Fixes #1261
Fixes #1256
Fixes #1255
Fixes #1252
Fixes #1184
Fixes #932
Fixes #478
Are answers expected to change (and if so in what way)? For Clm51 with BHS
yes. lma will be different from 0.25 and vary across pfts based on slatop. num_iter will be different b/c currently it is not within a patch loop.
clm5_0 non-Crop are different because of parameter file change
SOILWATER_10CM and TOTSOILLIQ change answers because they are summed later and after all updates in the field they operate on.
Any User Interface Changes (namelist or namelist defaults changes)? New params files
Testing performed, if any: regular testing