Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't turn FUN on with CLM4.5 due to defaults being too specific for br_root #885

Closed
billsacks opened this issue Jan 13, 2020 · 0 comments · Fixed by #897
Closed

Can't turn FUN on with CLM4.5 due to defaults being too specific for br_root #885

billsacks opened this issue Jan 13, 2020 · 0 comments · Fixed by #897
Assignees
@negin513
Labels
bfb bit-for-bit bug something is working incorrectly

Comments

@billsacks
Copy link
Member

billsacks commented Jan 13, 2020 •
edited
Loading

Brief summary of bug

An attempt to turn on use_fun with clm4.5 leads to the following error:

ERROR : CLM build-namelist::CLMBuildNamelist::add_default() : No default value found for br_root.
            Are defaults provided for this resolution and land mask?

General bug information

CTSM version you are using: ctsm1.0.dev080

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: clm4.5 with FUN

Details of bug

It appears that the namelist_defaults for br_root are too specific: they have a default specified for phys="clm5_0" use_cn=".true." use_fun=".true.", but it's allowable to turn on use_fun even with clm4.5. There is already logic in CLMBuildNamelist that prevents setting br_root without use_fun, and there doesn't seem to be any purpose to having these attributes in namelist_defaults, so I propose simplifying namelist_defauts to:

diff --git a/bld/namelist_files/namelist_defaults_ctsm.xml b/bld/namelist_files/namelist_defaults_ctsm.xml
index a32c807f..ceaeba09 100644
--- a/bld/namelist_files/namelist_defaults_ctsm.xml
+++ b/bld/namelist_files/namelist_defaults_ctsm.xml
@@ -954,7 +954,7 @@ lnd/clm2/surfdata_map/surfdata_ne120np4_78pfts_CMIP6_simyr1850_c170824.nc</fsurd
 <use_fun phys="clm5_0" use_cn=".true." use_nitrif_denitrif=".true.">.true.</use_fun>
 <use_fun                                                           >.false.</use_fun>
 
-<br_root phys="clm5_0" use_cn=".true." use_fun=".true.">0.83d-06</br_root>
+<br_root>0.83d-06</br_root>
 
 <!-- Scalar of leaf respiration to vcmax (used for SP mode and with luna)-->
 <leaf_mr_vcm phys="clm5_0" >0.015d00</leaf_mr_vcm>

However, from talking with @wwieder , you should only be allowed to turn on use_fun if you are also using FlexCN. I don't think CLMBuildNamelist checks for this right now, but it should. (Update: I have opened #886 for this other issue.)
@billsacks billsacks added tag: simple bfb bug something is working incorrectly labels Jan 13, 2020
pengbinpeluo added a commit to pengbinpeluo/ctsm that referenced this issue Jan 13, 2020
@pengbinpeluo
This fix a bug related with turning FUN on within CLM4.5
6a586ed 
More information at ESCOMP#885
@negin513 negin513 mentioned this issue Jan 24, 2020
Merged
billsacks added a commit that referenced this issue Feb 6, 2020
@billsacks
Merge branch 'bfb_pr_1'
5cc4ede 
Some BFB Fixes: Resolve issues #683, # 874, #878, # 885, # 745, #838

Resolved issues:

#683 :  Writing out FATES parameters only on masterproc.
#874 :  Changing the number of timesteps to run for
                   SMS_P720x1_Ln3.hcru_hcru.I2000Clm50BgcCruGs.cheyenne_intel.clm-coldStart
                   to prevent failing with CMEPS.
#878 :  Removing the unused atm2lnd field.
#885 :  Changing the defaults for br_root in namelist_defaults to
                   enable FUN with CLM4.5.
#745 :  Removing ReadNL private subroutine from initVerticalMod.F90.
#838 :  Clarifying ZISNO in the variable long name.
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negin513 negin513

Labels
bfb bit-for-bit bug something is working incorrectly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some BFB Fixes: Resolve issues #683, # 874, #878, # 885, # 745, #838. negin513/ctsm
3 participants
@billsacks @samsrabin @negin513