Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify zisno levels in the variable long name #838

Closed
billsacks opened this issue Nov 12, 2019 · 0 comments · Fixed by #897
Closed

Clarify zisno levels in the variable long name #838

billsacks opened this issue Nov 12, 2019 · 0 comments · Fixed by #897
Assignees
@negin513
Labels
bfb bit-for-bit documentation additions or edits to user-facing documentation good first issue simple; good for first-time contributors

Comments

@billsacks
Copy link
Member

At least on the restart file, zisno only contains levsno levels, even though it applies at interfaces rather than centers. We should clarify in the variable long name: zisno(c,j) gives the interface depth at the TOP of layer j. (I guess that the interface depth at the bottom of the snow pack isn't given explicitly because it is always 0 – i.e., at the snow-soil interface.)

Thanks to @timhoar for pointing this out.
@billsacks billsacks added good first issue simple; good for first-time contributors tag: simple bfb documentation additions or edits to user-facing documentation labels Nov 12, 2019
negin513 added a commit to negin513/ctsm that referenced this issue Jan 23, 2020
@negin513
clarifying zisno levels in the variable long name (Issue ESCOMP#838)
ae8b800
negin513 added a commit to negin513/ctsm that referenced this issue Jan 23, 2020
@negin513
rewording of zisno levels variable long name (Issue ESCOMP#838)
074381e
@negin513 negin513 mentioned this issue Jan 24, 2020
Merged
negin513 added a commit to negin513/ctsm that referenced this issue Jan 29, 2020
@negin513
clarifying zisno levels in the variable long name (Issue ESCOMP#838)
da9670c
negin513 added a commit to negin513/ctsm that referenced this issue Jan 29, 2020
@negin513
rewording of zisno levels variable long name (Issue ESCOMP#838)
a8c0b5e
negin513 added a commit to negin513/ctsm that referenced this issue Feb 6, 2020
@negin513
clarifying zisno levels in the variable long name (Issue ESCOMP#838)
793ecfb
negin513 added a commit to negin513/ctsm that referenced this issue Feb 6, 2020
@negin513
rewording of zisno levels variable long name (Issue ESCOMP#838)
888d925
billsacks added a commit that referenced this issue Feb 6, 2020
@billsacks
Merge branch 'bfb_pr_1'
5cc4ede 
Some BFB Fixes: Resolve issues #683, # 874, #878, # 885, # 745, #838

Resolved issues:

#683 :  Writing out FATES parameters only on masterproc.
#874 :  Changing the number of timesteps to run for
                   SMS_P720x1_Ln3.hcru_hcru.I2000Clm50BgcCruGs.cheyenne_intel.clm-coldStart
                   to prevent failing with CMEPS.
#878 :  Removing the unused atm2lnd field.
#885 :  Changing the defaults for br_root in namelist_defaults to
                   enable FUN with CLM4.5.
#745 :  Removing ReadNL private subroutine from initVerticalMod.F90.
#838 :  Clarifying ZISNO in the variable long name.
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negin513 negin513

Labels
bfb bit-for-bit documentation additions or edits to user-facing documentation good first issue simple; good for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some BFB Fixes: Resolve issues #683, # 874, #878, # 885, # 745, #838. negin513/ctsm
3 participants
@billsacks @samsrabin @negin513