-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In init_interp: If a given type cannot be found: Consider using something other than bare ground #54
Comments
Erik Kluzek < [email protected] > - 2017-01-19 10:37:48 -0700 In bug 2410 I present a suggested solution for how this would work by adding an optional flag to restartvar "ifmissingfrompft" that would give the PFT index to use when interpolating (defaults to 0 bare-soil). |
Bill Sacks < [email protected] > - 2017-01-19 13:20:12 -0700 The idea presented in bug 2410 won't work. I think we'd need something like that that is NOT tied to individual restart variables, but rather is some field that applies to all variables. |
new single column functionality
update to fetch tag first
a60032499 Merge tag 'v0.8.2' into tmp-release 75a0337 Bump to 0.8.2 7136066 Merge pull request ESCOMP#54 from ESMCI/fix/tag-not-found a90de4f update to fetch tag first a6e43fc Bump to 0.8.1 229ba03 Merge pull request ESCOMP#53 from ESMCI/fix/ssh_access e9cd2be better fix for issue with ssh access c624b61 Bump to 0.8.0 6ccf617 Merge pull request ESCOMP#51 from ESMCI/fix/recursive 53fce57 no need to make submodule objects persist dae1c82 now working with issue ESCOMP#50 ded91fd all tests passing, issue ESCOMP#50 fixed 62a338b all pytests now passing 143abac tests a-d all pass 2b021fd add documentation to submodule.py 72211d2 add the new submodule class 82dd7a4 test_b_update now working a7d8b4e all pytests passing 5322019 Bump to 0.7.9 1f07cb6 Merge pull request ESCOMP#49 from ESMCI/fix/fxDONOTUSEurl 31ce71b use poetry update to update poetry.lock file 46043f0 add code of conduct (issue ESCOMP#35) 0c3d683 dependabot changes and issue ESCOMP#48 25ccc15de Merge tag 'v0.7.8' into tmp-release 8eae7e3 Bump to 0.7.8 34daa06 Merge pull request ESCOMP#46 from ESMCI/add_optional_keyword af12c80 fix spelling 7ea36dc remove manage_externals error 2ede182 add optional to status output 4ff1e98de Merge tag 'v0.7.7' into tmp-release 87640ad Bump to 0.7.7 c124dc5 Merge pull request ESCOMP#43 from ESMCI/fix/root_dir 3ff935b update tests 0593149 one more improvement d95f5d6 fix status issue c304487 update complex test a34070b Bump to 0.7.6 9e5d5f7 Merge pull request ESCOMP#40 from ESMCI/fix/change_url 00b7b38 some fixes when modifying url git-subtree-dir: .lib/git-fleximod git-subtree-split: a600324993623cba8e663fcbfdb6a0f6832dd802
Bill Sacks < [email protected] > - 2017-01-17 19:35:14 -0700
Bugzilla Id: 2405
Bugzilla Depends: 2410,
Bugzilla CC: [email protected], [email protected], [email protected], [email protected],
In init_interp: Currently, if there is a type (patch or col type) in your new run that was not present in the "template" run, init_interp will use the closest bare ground patch as a template. This most likely occurs when you interpolate from a non-crop run to a crop run, or a crop-without-irrigation run to a crop-with-irrigation run. But in principle, it could occur in other circumstances, too.
This has sometimes caused problems, such as the recent problem where new crop types were given the rootfr of bare ground - which was 0 for all levels. We have fixed these problems as we have discovered them, but it's possible there are other problems lurking now, or that may be added later.
At today's CLM-CMT meeting, we discussed possibly wanting to change this behavior so that, rather than using the bare ground patch as a template in these cases, it uses some vegetated patch. It's not clear what the rules should look like for how to choose the appropriate vegetated patch; this requires more thought.
This could become more important if/when each PFT is put on its own column: In this case, taking column-level values from the bare ground patch would give you very-non-spun-up C & N pools, for example.
The text was updated successfully, but these errors were encountered: