-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change urban code to use downscaled atmospheric forcings #49
Labels
enhancement
new capability or improved behavior of existing capability
priority: low
Background task that doesn't need to be done right away.
Comments
billsacks
added
enhancement
new capability or improved behavior of existing capability
priority: low
Background task that doesn't need to be done right away.
labels
Dec 16, 2017
Bill Sacks < [email protected] > - 2016-11-15 05:09:32 -0700 To see what to change for the two "once this is done" points in my original report, look for comments like this that I'm adding in the code: BUG(wjs, 2016-11-15, bugz 2377) |
samsrabin
pushed a commit
to samsrabin/CTSM
that referenced
this issue
Apr 19, 2024
Jedwards/namelist cleanup Description of changes Replace DATM_CLMNCEP_YR and DATM_CPLHIST_YR with DATM_YR - there is no need to distinguish these. Also change scol_mode = 'true' and create_mesh = 'true' in namelist_definition_datm.xml with mode='single_column', mode='create'. Tested aux_cdeps (against feb0121) and cmeps testlist_drv (against jan17) Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are there dependencies on other component PRs CIME (list) CMEPS (list) Are changes expected to change answers? bit for bit different at roundoff level more substantial Any User Interface Changes (namelist or namelist defaults changes)? Yes See description above. No Testing performed: (required) aux_cdeps machines and compilers: Cheyenne intel details (e.g. failed tests): All pass (optional) CESM prealpha test machines and compilers details (e.g. failed tests): Hashes used for testing: CIME repository to check out: https://github.com/ESCOMP/CESM.git branch: master hash:ef6b28c80 CMEPS repository to check out: https://github.com/ESCOMP/CESM.git branch: master hash:ff6ec1977 CESM repository to check out: https://github.com/ESCOMP/CESM.git branch: nuopc_dev hash:c019fc221
jedwards4b
added a commit
to jedwards4b/ctsm
that referenced
this issue
Jul 5, 2024
Fix/fx donotus eurl
ekluzek
added a commit
to ekluzek/CTSM
that referenced
this issue
Jul 11, 2024
a60032499 Merge tag 'v0.8.2' into tmp-release 75a0337 Bump to 0.8.2 7136066 Merge pull request ESCOMP#54 from ESMCI/fix/tag-not-found a90de4f update to fetch tag first a6e43fc Bump to 0.8.1 229ba03 Merge pull request ESCOMP#53 from ESMCI/fix/ssh_access e9cd2be better fix for issue with ssh access c624b61 Bump to 0.8.0 6ccf617 Merge pull request ESCOMP#51 from ESMCI/fix/recursive 53fce57 no need to make submodule objects persist dae1c82 now working with issue ESCOMP#50 ded91fd all tests passing, issue ESCOMP#50 fixed 62a338b all pytests now passing 143abac tests a-d all pass 2b021fd add documentation to submodule.py 72211d2 add the new submodule class 82dd7a4 test_b_update now working a7d8b4e all pytests passing 5322019 Bump to 0.7.9 1f07cb6 Merge pull request ESCOMP#49 from ESMCI/fix/fxDONOTUSEurl 31ce71b use poetry update to update poetry.lock file 46043f0 add code of conduct (issue ESCOMP#35) 0c3d683 dependabot changes and issue ESCOMP#48 25ccc15de Merge tag 'v0.7.8' into tmp-release 8eae7e3 Bump to 0.7.8 34daa06 Merge pull request ESCOMP#46 from ESMCI/add_optional_keyword af12c80 fix spelling 7ea36dc remove manage_externals error 2ede182 add optional to status output 4ff1e98de Merge tag 'v0.7.7' into tmp-release 87640ad Bump to 0.7.7 c124dc5 Merge pull request ESCOMP#43 from ESMCI/fix/root_dir 3ff935b update tests 0593149 one more improvement d95f5d6 fix status issue c304487 update complex test a34070b Bump to 0.7.6 9e5d5f7 Merge pull request ESCOMP#40 from ESMCI/fix/change_url 00b7b38 some fixes when modifying url git-subtree-dir: .lib/git-fleximod git-subtree-split: a600324993623cba8e663fcbfdb6a0f6832dd802
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
new capability or improved behavior of existing capability
priority: low
Background task that doesn't need to be done right away.
Bill Sacks < [email protected] > - 2016-11-15 05:04:24 -0700
Bugzilla Id: 2377
Bugzilla CC: [email protected], [email protected],
Most of the code uses the downscaled, column-level atmospheric forcings where relevant. However, the urban code still uses the gridcell-level, non-downscaled forcings in some places (search for 'not_downscaled' in the urban modules). This is simply because, when I was originally changing the code to use the downscaled forcings, it looked like it would be a fair amount of work to change the urban code to be fully consistent, so I punted on that.
This causes problems if you extend either the urban domain or the CISM domain so that the two overlap in any grid cells - i.e., if there are any active urban points in the CISM domain.
Once this is done, we can:
(1) Remove the check for column-gridcell equality in atm2lndMod: check_downscale_consistency
(2) Remove the code that I'm about to add to glc2lndMod: update_glc2lnd_topo that prevents downscaling over urban points
The text was updated successfully, but these errors were encountered: