Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create humanIndexMod method to encapsulate humanindex calculations #106

Open
ekluzek opened this issue Dec 16, 2017 · 1 comment
Open

Create humanIndexMod method to encapsulate humanindex calculations #106

ekluzek opened this issue Dec 16, 2017 · 1 comment
Labels
code health improving internal code structure to make easier to maintain (sustainability) priority: low Background task that doesn't need to be done right away.

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 16, 2017

Erik Kluzek < erik > - 2014-10-13 15:42:05 -0600
Bugzilla Id: 2058
Bugzilla CC: dlawren, oleson,

Add methods to humanIndexMod to calculate the list of human index calculations...

calc_human_stress_indices()

run_indices_on_filter( numfilter, filter, … )
@ekluzek ekluzek added this to the clm5 milestone Dec 16, 2017
billsacks added a commit that referenced this issue Aug 22, 2018
@billsacks
Squashed 'manage_externals/' changes from 04273058..fc5acdab
dd6e011 
fc5acdab Merge pull request #114 from billsacks/fix_large_output_hang
aa2eb71d Try getting travis-ci working on MacOS
96842b46 Fix pylint errors
813fe3c2 pylint: disable useless-object-inheritance
c49d878a Rework execute_subprocess timeout handling
8fc0e5fb Cleanup from 'make style'
b0b23a6a Merge pull request #110 from gold2718/help_fix
3cbcd168 Fixed and clarified help documentation
025e6cb5 Merge pull request #107 from jedwards4b/ignore_empty_git_dir
489842b5 if you encounter an empty directory clone into it
0c5a2f69 Merge pull request #106 from billsacks/remove_logfile_message
7799e993 Remove message about checking the log file for more details

git-subtree-dir: manage_externals
git-subtree-split: fc5acdababc0855adb5599ebc2b303b12c88e900
billsacks added a commit that referenced this issue Aug 22, 2018
@billsacks
Squashed 'manage_externals/' changes from 04273058..fc5acdab
f1b18f8 
fc5acdab Merge pull request #114 from billsacks/fix_large_output_hang
aa2eb71d Try getting travis-ci working on MacOS
96842b46 Fix pylint errors
813fe3c2 pylint: disable useless-object-inheritance
c49d878a Rework execute_subprocess timeout handling
8fc0e5fb Cleanup from 'make style'
b0b23a6a Merge pull request #110 from gold2718/help_fix
3cbcd168 Fixed and clarified help documentation
025e6cb5 Merge pull request #107 from jedwards4b/ignore_empty_git_dir
489842b5 if you encounter an empty directory clone into it
0c5a2f69 Merge pull request #106 from billsacks/remove_logfile_message
7799e993 Remove message about checking the log file for more details

git-subtree-dir: manage_externals
git-subtree-split: fc5acdababc0855adb5599ebc2b303b12c88e900
billsacks added a commit that referenced this issue Aug 23, 2018
@billsacks
Squashed 'manage_externals/' changes from 04273058..fc5acdab
b08f444 
fc5acdab Merge pull request #114 from billsacks/fix_large_output_hang
aa2eb71d Try getting travis-ci working on MacOS
96842b46 Fix pylint errors
813fe3c2 pylint: disable useless-object-inheritance
c49d878a Rework execute_subprocess timeout handling
8fc0e5fb Cleanup from 'make style'
b0b23a6a Merge pull request #110 from gold2718/help_fix
3cbcd168 Fixed and clarified help documentation
025e6cb5 Merge pull request #107 from jedwards4b/ignore_empty_git_dir
489842b5 if you encounter an empty directory clone into it
0c5a2f69 Merge pull request #106 from billsacks/remove_logfile_message
7799e993 Remove message about checking the log file for more details

git-subtree-dir: manage_externals
git-subtree-split: fc5acdababc0855adb5599ebc2b303b12c88e900
ekluzek pushed a commit to ekluzek/CTSM that referenced this issue Oct 11, 2018
@billsacks @ekluzek
Squashed 'manage_externals/' changes from 04273058..fc5acdab
40dc83b 
fc5acdab Merge pull request ESCOMP#114 from billsacks/fix_large_output_hang
aa2eb71d Try getting travis-ci working on MacOS
96842b46 Fix pylint errors
813fe3c2 pylint: disable useless-object-inheritance
c49d878a Rework execute_subprocess timeout handling
8fc0e5fb Cleanup from 'make style'
b0b23a6a Merge pull request ESCOMP#110 from gold2718/help_fix
3cbcd168 Fixed and clarified help documentation
025e6cb5 Merge pull request ESCOMP#107 from jedwards4b/ignore_empty_git_dir
489842b5 if you encounter an empty directory clone into it
0c5a2f69 Merge pull request ESCOMP#106 from billsacks/remove_logfile_message
7799e993 Remove message about checking the log file for more details

git-subtree-dir: manage_externals
git-subtree-split: fc5acdababc0855adb5599ebc2b303b12c88e900
@ekluzek ekluzek removed this from the clm5 milestone Aug 11, 2019
@ekluzek ekluzek added code health improving internal code structure to make easier to maintain (sustainability) priority: low Background task that doesn't need to be done right away. labels Aug 11, 2019
@ekluzek
Copy link
Collaborator Author

ekluzek commented Aug 11, 2019

This has partially already been done. HumanIndexMod is a module with a list of subroutines to do the different calculations. Subroutines that call it still call the list of subroutines, and decide if they should all be called or just the fast ones. So this could use more cleanup to make it more modular.

slevis-lmwg pushed a commit to slevis-lmwg/ctsm that referenced this issue Dec 22, 2022
@ekluzek
Squashed 'manage_externals/' changes from 5fc8709..fde04e4
317b860 
fde04e4 Merge pull request ESCOMP#138 from billsacks/add_python38_tests
37e4c4a Do not update dictionary in-place in loop
7e8474b Remove testing on mac os
7f41c56 Fix pylint issue
3065b0d Add travis-ci tests with python3.7 and python3.8
34fbf55 Add support for git sparse checkout
6c6ef9f Fix pylint errors
6a659ad Added test for sparse checkout and updated documentation
1443243 Support for git sparsecheckout via read-tree.
a48558d Merge pull request ESCOMP#119 from gold2718/submodules
f72ffe7 Do not try git submodule update if no .gitmodules file (git bug)
804e0af Fix a pylint error
45aef95 Addressed review concerns
7da5031 New capability to use git submodule information to checkout externals
1926530 Merge pull request ESCOMP#118 from mnlevy1981/svn_switch
b1b028d Updates after testing
9ea73e6 Add --svn-ignore-ancestry argument
fc5acda Merge pull request ESCOMP#114 from billsacks/fix_large_output_hang
aa2eb71 Try getting travis-ci working on MacOS
96842b4 Fix pylint errors
813fe3c pylint: disable useless-object-inheritance
c49d878 Rework execute_subprocess timeout handling
8fc0e5f Cleanup from 'make style'
b0b23a6 Merge pull request ESCOMP#110 from gold2718/help_fix
3cbcd16 Fixed and clarified help documentation
025e6cb Merge pull request ESCOMP#107 from jedwards4b/ignore_empty_git_dir
489842b if you encounter an empty directory clone into it
0c5a2f6 Merge pull request ESCOMP#106 from billsacks/remove_logfile_message
7799e99 Remove message about checking the log file for more details
0427305 Merge pull request ESCOMP#103 from billsacks/no_logging
9bb46aa Make no-logging be the default
9af6b02 Merge pull request ESCOMP#102 from billsacks/explain_qmark
7f973ae Run through make style
d077a57 Add message describing meaning of '?'
60fc03b Merge pull request ESCOMP#101 from ESMCI/catch_svn_error
28073ec add exception class
4fb7e47 catch errors from svn status --xml
bfa4831 Merge pull request ESCOMP#98 from billsacks/quieter
7d12650 make style
afb4f11 Make more git and svn commands quieter
a465b4f add --quiet argument to improve performance
b2f3ae8 Merge pull request ESCOMP#83 from jedwards4b/jedwards/components_arg
3f4c88f fix comment
c1b5b09 remove unneeded logic
4fdf180 one more test
f78d60f another test
bf52ac6 add a test
91d4851 fix pylint issue
987df5a only use components if populated
98a810d add a components arg to checkout only select components
6923119 Merge pull request ESCOMP#90 from ESMCI/issue-86-detached-sync-status
b11ad61 Merge branch 'master' into issue-86-detached-sync-status
3b624cf Merge pull request ESCOMP#93 from billsacks/work_on_coverage
2562830 Run a single coverage command rather than two separate commands
d1de5f8 Return to starting directory after each test
144f7d9 Merge pull request ESCOMP#92 from billsacks/point_to_esmci
58b8d3e Point to location of repository
0b46d81 Point to correct location for build/coverage status
a385070 fix pylint problems
dcf17b6 make style cleanup
92d342c Rewrite _current_ref to use plumbing rather than parsing porcelain
ca0a5d3 Rework some git repository functions, and major rework of unit tests
719383e Remove commented-out pdb.set_trace() call
376c780 Bugfix: detect and report 'detached from' correctly
21813e9 Add system test demonstrating failure to detect out of sync status.
1a7c59d Merge documentation update into master.
f1e9e99 Merge schema support for git hashes into master.
247fee1 Document return values of checkout.py: main
195c1d0 Implement explicit use of a hash for git repositories.
12dd743 Refactor: schema validation output
fdbc720 Bugfix: incorrect order of operations validing user input
d6423c6 Bugfix: timeout limit for subprocesses
7998f60 Update readme and help output
00b6fb2 Bugfix: add explicit schema version checking
0527869 Update readme
1ae8c84 Merge bugfix branch for stale subexternals into master.
b0c16d7 Bugfix: stale sub-externals after checkout.
30a4e44 Finish implementing system test for mixed-use externals
ac7ff96 Update mixed-use test repo.
bfda7b9 Bugfix: regexp for determining git tracking branches

git-subtree-dir: manage_externals
git-subtree-split: fde04e4d9a758b3aa277aa5fa44a59f5153f2958
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@jedwards4b
Merge pull request ESCOMP#106 from jedwards4b/cdeps_SourceMods_fix
e32614f 
### Description of changes
CDEPS build was not incorporating files from the SourceMods file path. This fixes that issue by searching the cdeps relevent directories in SourceMods.

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list)

Are changes expected to change answers?
 - [X] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [X] No

Testing performed:
- [X] (required) aux_cdeps
   - machines and compilers: cheyenne intel, ALL PASS
   - details (e.g. failed tests):
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash:4961a210a03
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch:master
  - hash:cmeps0.13.15
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch:
  - hash:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health improving internal code structure to make easier to maintain (sustainability) priority: low Background task that doesn't need to be done right away.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ekluzek