Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add werror to extbuild #333

Merged
merged 39 commits into from
Jan 9, 2023

Conversation

jedwards4b
Copy link
Collaborator

@jedwards4b jedwards4b commented Jan 4, 2023

Description of changes

Add werror to github testing - no gfortran warnings allowed.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
BFB
Any User Interface Changes (namelist or namelist defaults changes)? NO

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers cheyenne, intel, gnu, github testing.
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@jedwards4b jedwards4b self-assigned this Jan 4, 2023
@jedwards4b jedwards4b requested review from DeniseWorthen and billsacks and removed request for billsacks January 4, 2023 23:08
@jedwards4b
Copy link
Collaborator Author

I will run cesm prealphas with this + CDEPS ESCOMP/CDEPS#207

@jedwards4b
Copy link
Collaborator Author

@uturuncoglu could you also review this one?

@jedwards4b jedwards4b requested a review from uturuncoglu January 6, 2023 17:11
@uturuncoglu
Copy link
Collaborator

@jedwards4b maybe I could test both of them in the same time.

@jedwards4b
Copy link
Collaborator Author

Yes - please do!

@DeniseWorthen
Copy link
Collaborator

@uturuncoglu What testing are you planning? I don't want to replicate anything you were going to do on UFS.

@uturuncoglu
Copy link
Collaborator

@DeniseWorthen Since i need to test CDEPS PR. I think that could run couple of coupled test but if you want to run the entire RT against this PR please go ahead and I could test CDEPS seperately.

@DeniseWorthen
Copy link
Collaborator

@uturuncoglu Sure, will do.

Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All UFS tests passed.

@jedwards4b jedwards4b merged commit 6d4c1ff into ESCOMP:master Jan 9, 2023
@jedwards4b jedwards4b deleted the add_werror_to_github_tests branch January 9, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants