code cleanup

[jedwards4b]

Description of changes

Remove all gfortran warnings except unused-dummy-argument with the exception of the external fox code.

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed #204

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes): no

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): cesm prealphas on cheyenne with intel and gnu and updated github testing.

Hashes used for testing: cesm2.3.beta11 + cmeps 2ded3b5
cdeps 7bd2b80

[jedwards4b]

@mvertens @uturuncoglu I have added the -Werror flag to the github tests for directories excluding fox.
This will cause any gnu compiler warning in cdeps to generate an error in the github testing.

[jedwards4b]

I should say that I did add one exception: -Wno-unused-dummy-argument because the callbacks from esmf sometimes include import and export State variables that are not used.

[jedwards4b]

@uturuncoglu can you review this please?

[mvertens]

@jedwards4b - thanks so much for doing this. Can we arrange a time to chat to go over your changes in more detail. I have several questions that would be resolved much more quickly in a chat.

[jedwards4b]

@mvertens sure.

[uturuncoglu]

@jedwards4b I'll test this under UFS. I also need to test the standalone build to be sure that it is not breaking anything in datm+land GitHub Action in NoahMP side. That could take little bit time but I'll try to finish them today.

[uturuncoglu]

@jedwards4b i tested under UFS by running couple of datm RTs incl. restart and all are passed. So, there is no issue under UFS. I'll try to test standalone build too and let you know.

[uturuncoglu]

@jedwards4b I am not sure why but I am getting error under Docker container that uses Ubuntu and following fortran version

gcc version 11.3.0 (Ubuntu 11.3.0-1ubuntu1~22.04)

the error is

/test/CDEPS/share/shr_infnan_mod.F90.in:73:20:

   73 | #endif
      |                    1
Error: Procedure 'shr_infnan_isnan_real' in generic interface 'shr_infnan_isnan' at (1) is neither function nor subroutine; did you mean 'shr_infnan_isinf_real'?
make[2]: *** [share/CMakeFiles/cdeps_share.dir/build.make:87: share/CMakeFiles/cdeps_share.dir/shr_infnan_mod.F90.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:395: share/CMakeFiles/cdeps_share.dir/all] Error 2

maybe this is not related with this PR but I am not getting this error from my fork

https://github.com/uturuncoglu/CDEPS/tree/hotfix/std_build

[jedwards4b]

Is -DCPRGNU defined in your test build?

[uturuncoglu]

@jedwards4b No. how can I define it? If I give it like -DCPRGNU=ON to cmake command it complains. BTW, I am trying to update my branch with CDEPS/master and plan to test again. If it works, I'll merge with your fork as a next step to test it.

[jedwards4b]

I think if you set CPPDEFS="-DCPRGNU" in the environment before invoking cmake

[jedwards4b]

Or as in the github workflow here.

[uturuncoglu]

@jedwards4b Okay. The GitHub way worked. Thanks. I could able to compile it now.

Probably I'll open another PR later to fix the FoX library issue because the standalone build is forcing FoX and if you would like to use ESMF Config format for stream namelist it is not possible. I have a fix in my fork that enables it by bringing -DDISABLE_FoX=ON option.