-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cime stream xml modifications now made from user_nl_xxx_streams files #117
Conversation
@@ -142,9 +133,9 @@ def buildnml(case, caseroot, compname): | |||
|
|||
# NOTE: User definition *replaces* existing definition. | |||
files = Files(comp_interface="nuopc") | |||
definition_file = [files.get_value("NAMELIST_DEFINITION_FILE", {"component":"docn"})] | |||
definition_file = [files.get_value("NAMELIST_DEFINITION_FILE", {"component":compname})] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this change to compname makes this subroutine generic perhaps we should move it to a shared location and remove it from individual components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvertens Let me try to run at least one data configuration under HAFS to see what happens. I am not expecting any issue but it would be nice to test it an any case.
Description of changes
cime stream xml modifications now made from user_nl_xxx_streams files
Specific notes
This PR changes modifications to stream xml files only through modifying new user_nl_xxx_stream files in the user's CASEROOT directory.
Contributors other than yourself, if any: @jedwards4b @ekluzek
CMEPS Issues Fixed: #76 #79
Are there dependencies on other component PRs
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed:
Hashes used for testing: