Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cime stream xml modifications now made from user_nl_xxx_streams files #117

Merged
merged 7 commits into from
Aug 26, 2021

Conversation

mvertens
Copy link
Collaborator

Description of changes

cime stream xml modifications now made from user_nl_xxx_streams files

Specific notes

This PR changes modifications to stream xml files only through modifying new user_nl_xxx_stream files in the user's CASEROOT directory.

Contributors other than yourself, if any: @jedwards4b @ekluzek

CMEPS Issues Fixed: #76 #79

Are there dependencies on other component PRs

  • CIME (CIME PR #4074)
  • CMEPS (list)

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes - xml stream files can now be modified from user_nl_xxx_streams where xxx =[atm,ice,ocn,lnd,rof,wav]
  • No

Testing performed:

  • (required) aux_cdeps
    • machines and compilers: intel/cheyenne
    • details (e.g. failed tests): compared to cdeps0.12.18 and generated cdeps0.12.22
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

cime_config/stream_cdeps.py Outdated Show resolved Hide resolved
datm/cime_config/buildnml Show resolved Hide resolved
@@ -142,9 +133,9 @@ def buildnml(case, caseroot, compname):

# NOTE: User definition *replaces* existing definition.
files = Files(comp_interface="nuopc")
definition_file = [files.get_value("NAMELIST_DEFINITION_FILE", {"component":"docn"})]
definition_file = [files.get_value("NAMELIST_DEFINITION_FILE", {"component":compname})]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this change to compname makes this subroutine generic perhaps we should move it to a shared location and remove it from individual components?

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvertens Let me try to run at least one data configuration under HAFS to see what happens. I am not expecting any issue but it would be nice to test it an any case.

streams/dshr_strdata_mod.F90 Show resolved Hide resolved
@jedwards4b jedwards4b self-requested a review August 26, 2021 13:31
@jedwards4b jedwards4b merged commit d3c5e67 into ESCOMP:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to modify individual streams.xml settings with something like user_nl_datm or xmlchange
3 participants