Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When overriding datm.streams.xml file with a user version it doesn't modify datm.input_data_list by the actual file list in the user file #79

Closed
ekluzek opened this issue Apr 30, 2021 · 2 comments
Closed

When overriding datm.streams.xml file with a user version it doesn't modify datm.input_data_list by the actual file list in the user file #79

ekluzek opened this issue Apr 30, 2021 · 2 comments
Assignees
@jedwards4b
Labels
bug Something isn't working

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Apr 30, 2021

When you override the datm.streams.xml file with a file in your $CASEDIR, it doesn't use the new list of files or the yearFirst and yearLast to determine the file list. It does use the stream file from the $CASEDIR, but it doesn't change datm.input_data_list by what's in the user file. Since, the inpudata_data_list is updated with each run of preview_namelists this makes it difficult to use if the reason you changed the streams file is because of missing files.
@mvertens mvertens added the bug Something isn't working label May 10, 2021
@jedwards4b jedwards4b mentioned this issue May 12, 2021
Merged
12 tasks
jedwards4b added a commit that referenced this issue May 14, 2021
@jedwards4b
Merge pull request #88 from jedwards4b/streams_improvement
b85dcd0 
### Description of changes
Improve support for user mods in *.streams.xml file.  If the file is found in the run directory it will be used for that data components streams.  I have added an xsd file as well to use with xmllint to assure the syntax of the file.  Due to namelist change in cmeps for multiple ice sheets all namelists changed and so new baselines, may12, were generated.  

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): #79 

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [X] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [X] Yes Indirectly due to changes in glc (multiple ice sheet support)
 - [ ] No

Testing performed:
- [X] (required) aux_cdeps
   - machines and compilers: cheyenne intel 
   - details (e.g. failed tests): see issue #89 
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: 353730e
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: cf0d47b
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
@mvertens mvertens mentioned this issue Aug 25, 2021
Merged
12 tasks
@billsacks
Copy link
Member

Is this still an issue, or has it been solved / superseded?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 3, 2021

I just tried this in my externals update branch and it looks like it works correctly now. So I'm closing this.

@ekluzek ekluzek closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards4b jedwards4b

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jedwards4b @billsacks @mvertens @ekluzek