-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helper size reduction #378
Conversation
Hey @Azrael-Kun, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
191dfd2
to
3c8ed8e
Compare
Hey @EPMatt, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
Hi @Azrael-Kun, thank you so much for your kind contribution. I've added a few minor changes to your submission:
Since my changes do not introduce any functionality change and you've already performed tests successfully, I'm now proceeding to merge this PR into Thank you so much for such a great contribution! You're really helping the project grow with your work. 🔥 |
* Add helper reduction to e2001/e2002 * Update all controllers with new helper * helper size reduction for sonoff_snzb01 * fix blueprint comments * bump versions to 2022.08.08, update changelogs Co-authored-by: Matteo Agnoletto <[email protected]>
Hi there, 🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR. Thanks! |
This pull request reworks the
helper_last_controller_event
entity to use less characters (see #333).I tested the e2001/e2002 blueprint with custom actions and once confirmed working went through and updated all the other blueprints.
Breaking change
There should not be any breaking changes as the new regex_match should cause existing entities to be updated to the new format on first use.
Proposed change*
{"trigger_action": "off", "last_triggered": "2022-05-05 09:58:25.740583+02:00"}
with{"a": "off", "t": <unix time>}
{"a": "", "t": 1658511756.518805}
)move_to_level_with_on_off
)"a": ".*"
or"t": \d+.\d+
in either orderCloses #333
Checklist*
npm run format
before submitting my Pull Request.