-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SONOFF SNZB-01 #376
Conversation
Hey @Azrael-Kun, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
Hey @Azrael-Kun, ✅ Your contribution passed all the checks, awesome! Thanks again for dedicating your precious time to this project. 🔥 📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links. https://github.com/Azrael-Kun/awesome-ha-blueprints/blob/sonoff_snzb01/blueprints/controllers/sonoff_snzb01/sonoff_snzb01.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Azrael-Kun,
I'll perform a deeper code review tomorrow and check if something is missing, but overall this looks good to me.
Thank you so much for your contribution! This controller will be a great addition to our collection. :)
Hey @EPMatt, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
Hey @EPMatt, ✅ Your contribution passed all the checks, awesome! Thanks again for dedicating your precious time to this project. 🔥 📝 Updated blueprints included in this PR can be tested by importing them in Home Assistant via the following links. https://github.com/Azrael-Kun/awesome-ha-blueprints/blob/sonoff_snzb01/blueprints/controllers/sonoff_snzb01/sonoff_snzb01.yaml |
Hey @Azrael-Kun, as I previously assessed, your contribution looks perfect! I've just added a few minor changes to your submission:
Since these edits do not impact blueprint functionality and you've already successfully performed tests with ZHA, I'm now proceeding to merge this PR into Thank you so much for your precious work here! 🔥 |
* Add support for SONOFF SNZB-01 * add note for long press, bump versions to 2022.07.30 Co-authored-by: Matteo Agnoletto <[email protected]>
Hi there, 🔒 This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you want to submit a contribution to the project, you can open a new PR. Thanks! |
This pull request adds support for the SONOFF SNZB-01 Wireless Switch (see #321).
I have tested this using ZHA with just the controller blueprint and custom actions as well as connected to a light hook.
The deCONZ action maps I obtain from their button_maps file, and zigbee2mqtt from their device page on SNZB-01 and as provided in #321 but have not actually tested.
Proposed change*
Closes #321
Checklist*
npm run format
before submitting my Pull Request.