This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Improved performance of hexString to data init. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, nice work! Should we put in a unit test with a larger hex string decode and a timed expectation/wait to validate? |
opi-smccoole
approved these changes
Oct 21, 2019
I've added a larger hex string unit test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR highlighted an issue with hexString to Data parsing performance.
#207
I timed the large example hex string from that PR in a unit test and it took 56 seconds to parse.
With the changes in this PR parsing the same string took 0.005 of a second to parse.