This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Fix a performance issue with decoding base16 encoded string #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cut new version @0.0.2.
Release v0.0.3
Merge into Master
Merge Develop into Master
Release v0.1.0
Update docs for v0.1.0.
Update image in README.
Update docs.
Release v0.1.1
Merging recent README updates into Master
iCell
force-pushed
the
bugfix/base16-decode
branch
from
2483ca4 to
8c78465
Compare
|
@iCell Thanks for the bug report and PR. We'll get this processed and reviewed soon. |
Release v0.1.2
Release v0.1.3
merge updates from EOSIO main project
Merge eosio
merge updates from EOSIO
|
This is being fixed in #229. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a serious performance issue when decoding base16 encoded string. The corresponding code is EosioSwift/Extensions/DataExtensions.swift.
When we tested using stake action, the encoded hex string (which can be found here) passed to the Authenticator app, then the app decoded the string, and it stuck, maybe crash sometimes. Then we tested using transfer action, everything worked fine except we need to wait a long time in decoding.
So, we tried to imporve the method of decoding base16 encoded string, using the solution provided by mattrubin/Bases, which performed very well. But unfortunately, it does not support Cocoapods, so we forked the repo to support cocoapods.
From the results, the performance after replacing the decoding method is on the order of milliseconds, while the original decoding performance is ten seconds or even more.