Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

address feedback from #227 #228

Closed
wanderingbort opened this issue Aug 25, 2017 · 0 comments · Fixed by #245
Closed

address feedback from #227 #228

wanderingbort opened this issue Aug 25, 2017 · 0 comments · Fixed by #245
Assignees
@wanderingbort

Comments

@wanderingbort
Copy link
Contributor

This issue is to track the application of notes from the review of #227
@wanderingbort wanderingbort self-assigned this Aug 25, 2017
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 28, 2017
@wanderingbort
remove try/catch spam with immediate strings concatenated only when e…
ea8648c 
…xceptions are thrown. ref EOSIO#228
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 28, 2017
@wanderingbort
put inline inline... see what I did there? ref EOSIO#228
65a07be
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 28, 2017
@wanderingbort
remove transaction_helpers namespace in favor of method prefix, ref E…
81e9261 
…OSIO#228
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 28, 2017
@wanderingbort
Fix bug I explicitly introduced to test exception paths (then forgot …
1a472b5 
…about). ref EOSIO#228
@wanderingbort wanderingbort mentioned this issue Aug 28, 2017
Merged
wanderingbort added a commit to wanderingbort/eos that referenced this issue Aug 29, 2017
@wanderingbort
merge changes to master @913639a . ref EOSIO#228
8c34cd9
heipacker pushed a commit to TP-Lab/eos that referenced this issue Jan 12, 2019
Merge pull request EOSIO#228 from enumivo/stage143
a8c0926 
Stage143
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wanderingbort wanderingbort

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/228 feedback from 227 wanderingbort/eos
1 participant
@wanderingbort