Python: Fix Interactive Inspection #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
bug
ax3l
force-pushed
the
fix-py-jedi-getter-prop
branch
from
45f1a26 to
f0dc6d2
Compare
ax3l
commented
Sep 28, 2022
| void init_ImpactX(py::module& m) | ||
| namespace detail | ||
| { | ||
| /** Helper Function for Property Getters |
There was a problem hiding this comment.
We can check in the future if we find a reasonable location to set default parameters without setting them multiple times throughout the code.
Maybe we need a ReadParameters-like function called set_default_parameters after all... :-S
When autocompleting the `ImpactX()` Python class, Ipython uses Jedi to look into the getters of properties. By default, the `ParmParse::get()` we use would throw an `amrex::Abort()`, which exits the interpreter. We could and should use `amrex.throw_exception = 1` and `amrex.signal_handling = 0` to make this a `std::runtime_error`. Unfortunately, this is still not sufficient to catch it, because C++ exception handlign accross shared libraries needs extra care. Thus, we just do a helper function, save some lines of code, and throw directly from ImpactX's Python module.
ax3l
force-pushed
the
fix-py-jedi-getter-prop
branch
from
dfcc4a8 to
3c9c3c8
Compare
This was referenced Sep 28, 2022
|
Also doesn't crash on Mac, anymore. ✨ |
RTSandberg
reviewed
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autocompleting the
ImpactX()Python class, IPython uses Jedi to look into the getters of properties.By default, the
ParmParse::get()we use would throw anamrex::Abort(), which exits the interpreter.We could and should use
amrex.throw_exception = 1andamrex.signal_handling = 0to make this astd::runtime_error. Unfortunately, this is still not sufficient to catch it, because C++ exception handling across shared libraries needs extra care.Thus, we just do a helper function, save some lines of code, and throw directly from ImpactX's Python module.
Thanks to @n01r for spotting this originally.
Follow-up to #260 and #223