Add Unused Parameter Warnings

[n01r]

Adds warnings about unused parameters like in WarpX as requested in #120

• Can you please check if amrex.abort_on_unused_inputs = 1 works already as well?
• This one needs to be documented in both WarpX and AMReX docs, please.
• We need to please document warpx.abort_on_warning_threshold (or equivalent) in ImpactX.
• implemented it like in WarpX but it does not abort, yet, when I do some warning logger testing as described in the WarpX docs
• move impl to separate .cpp file
• add Python control
• add docs for Python control
• [ ] add Python tests for unused inputs and for warning in tests/python/test_impactx.py skipped for follow-up since more testing is needed

[ax3l]

Thanks!

• Can you please check if amrex.abort_on_unused_inputs = 1 works already as well?
• This one needs to be documented in both WarpX and AMReX docs, please.
• We need to please document warpx.abort_on_warning_threshold (or equivalent) in ImpactX.

[n01r]

Setting amrex.abort_on_unused_inputs = 1 and having an unused input does not abort the sim, yet.

It works, but it aborts after the sim runs through which first confused me.

[ax3l]

Thanks, please don't forget adding user-facing docs.

[n01r]

We need to please document warpx.abort_on_warning_threshold (or equivalent) in ImpactX.

I think this additional implementation of these options and maybe it justifies creating a function ImpactX::ReadParameters like the existing one in WarpX.

[ax3l]

The nice thing about amrex::ParmParse is, that you can read parameters anywhere. For which current collection of parameters do you suggest grouping in a ReadParameters?

Please let me know when these items are ready (#223 (comment)) and this can be merged :) I moved them as to-do's in the PR description.

[n01r]

The nice thing about amrex::ParmParse is, that you can read parameters anywhere. For which current collection of parameters do you suggest grouping in a ReadParameters?

Why not sort all? In WarpX it seems they are all grouped into a ReadParameters function and every group has its own context like:

    {
        ParmParse pp_<context>("< context >");
        pp_<context>.query("name-of-some-option")
    }

Please let me know when these items are ready (#223 (comment)) and this can be merged :) I moved them as to-do's in the PR description.

• Can you please check if amrex.abort_on_unused_inputs = 1 works already as well?

this works already and user-facing docs have been added :)

• This one needs to be documented in both WarpX and AMReX docs, please.

• user-facing docs for WarpX: Docs: abort_on_unused_inputs WarpX#3364
• ~ for AMReX: Update Testing Docs AMReX-Codes/amrex#2937

• We need to please document warpx.abort_on_warning_threshold (or equivalent) in ImpactX.

• implemented it like in WarpX but it does not abort, yet, when I do some warning logger testing as described in the WarpX docs

[ax3l]

In WarpX it seems they are all grouped into a ReadParameters function ...

Minutes for what we discussed: We need no static member variables for states because we store our options directly in amrex::ParmParse. This also keeps us in sync which options take precedence for control from the Python side. Querying ParmParse is fast and can be done in-place instead of at the init stage only.

[ax3l]

Please add tests for this functionality as noted in the PR description

[n01r]

update: skipping Python tests for this PR as discussed this morning and doing them in a follow-up