Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

=& SC_Query_Exの修正 #1093

Merged
merged 3 commits into from
Dec 20, 2024
Merged

=& SC_Query_Exの修正 #1093

merged 3 commits into from
Dec 20, 2024

Conversation

nobuhiko
Copy link
Contributor

@nobuhiko nobuhiko commented Dec 20, 2024

Fixes #622

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.70%. Comparing base (be45d5e) to head (c4e3e7b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1093   +/-   ##
=======================================
  Coverage   51.70%   51.70%           
=======================================
  Files          80       80           
  Lines       10217    10217           
=======================================
  Hits         5283     5283           
  Misses       4934     4934           
Flag Coverage Δ
tests 51.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= &SC_Query というパターンも残存しているので、こちらも修正いただいてよろしいでしょうか🙇‍♂️
https://github.com/search?q=repo%3AEC-CUBE%2Fec-cube2%20%26SC_Query&type=code

@nanasess nanasess added this to the 2.18(仮) milestone Dec 20, 2024
@nanasess nanasess enabled auto-merge December 20, 2024 02:27
Copy link
Contributor

@nanasess nanasess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanasess nanasess merged commit 46e5e42 into EC-CUBE:master Dec 20, 2024
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC_Query_Ex::getSingletonInstance() 参照渡しが残っている
2 participants