Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC_Query_Ex::getSingletonInstance() 参照渡しが残っている #622

Closed
seasoftjapan opened this issue Oct 26, 2022 · 1 comment · Fixed by #1093
Closed

SC_Query_Ex::getSingletonInstance() 参照渡しが残っている #622

seasoftjapan opened this issue Oct 26, 2022 · 1 comment · Fixed by #1093
Assignees
@nobuhiko
Labels
good first issue
Milestone
2.18(仮)

Comments

@seasoftjapan
Copy link
Contributor

「=& SC_Query」で grep すると、18箇所ほど。

実害ありそうなのは、以下か。
html/admin/load_module_config.php
html/test/upgrade/index.php

意図的に変更していないなら、コメント記載して欲しい。

他は、tests/class/helper 以下。(ここは無視で良い?)
@nanasess
Copy link
Contributor

nanasess commented Nov 7, 2022

修正漏れだと思います

@nanasess nanasess added this to the 2.18(仮) milestone Dec 16, 2024
@nobuhiko nobuhiko self-assigned this Dec 20, 2024
nobuhiko added a commit to nobuhiko/ec-cube2 that referenced this issue Dec 20, 2024
@nobuhiko
fixed EC-CUBE#622
f0e8064
@nanasess nanasess mentioned this issue Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nobuhiko nobuhiko

Labels
good first issue
Projects
None yet
Milestone
2.18(仮)
Development

Successfully merging a pull request may close this issue.

=& SC_Query_Exの修正 nobuhiko/ec-cube2
3 participants
@nobuhiko @nanasess @seasoftjapan