Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mvm paths #472

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Fix mvm paths #472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3f6758
Fix mvm paths
forsyth2 Aug 4, 2023
fc038e4
Undo testing-only changes
forsyth2 Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zppy/templates/e3sm_diags.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ from e3sm_diags.parameter.tc_analysis_parameter import TCAnalysisParameter
from e3sm_diags.run import runner

short_name = '${short}'
test_ts = '${ts_dir_destination}'
test_ts = '${ts_dir_primary}'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, the mvm test actually wasn't generating plots. Multiple errors were going unnoticed, including:

IndexError: list index out of range
RuntimeError: Invalid year range specified for test/reference time series data: end_year=1853>1851=var_end_yr
RuntimeError: Requested years are outside of available sst obs records.
IndexError: index 0 is out of bounds for axis 0 with size 0

start_yr = int('${Y1}')
end_yr = int('${Y2}')
num_years = end_yr - start_yr + 1
Expand Down