Fix mvm paths #472
Merged
Fix mvm paths #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forsyth2
commented
Aug 4, 2023
| @@ -236,7 +236,7 @@ from e3sm_diags.parameter.tc_analysis_parameter import TCAnalysisParameter | |||
| from e3sm_diags.run import runner | |||
|
|
|||
| short_name = '${short}' | |||
| test_ts = '${ts_dir_destination}' | |||
| test_ts = '${ts_dir_primary}' | |||
There was a problem hiding this comment.
Without this change, the mvm test actually wasn't generating plots. Multiple errors were going unnoticed, including:
IndexError: list index out of range
RuntimeError: Invalid year range specified for test/reference time series data: end_year=1853>1851=var_end_yr
RuntimeError: Requested years are outside of available sst obs records.
IndexError: index 0 is out of bounds for axis 0 with size 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mvm paths. Resolves #471.