Add flags for GNU builds to allow using GNU v10 and higher versions #4822
Conversation
Add -fallow-argument-mismatch for all GNU builds (including gnugpu). Only add -fallow-invalid-boz for 2 specific files for gnu/gnugpu builds. This PR adds Depends.gnugpu.cmake which is similar to Depends.gnu.cmake [bfb]
| @@ -0,0 +1,24 @@ | |||
| list(APPEND MPAS_ICE_SHORTWAVE | |||
There was a problem hiding this comment.
Following the patterns of the other changes in this PR you might want to rename the list to DISABLE_TREE_PTA_LIST or something like that
There was a problem hiding this comment.
And you might want to amend the commit message to include this flag
There was a problem hiding this comment.
The MPAS_ICE_SHORTWAVE name was already there. It's fine to rename it...
I don't know what you mean about amending commit message
There was a problem hiding this comment.
The commit message (or PR desc) does not mention the new compiler flag, -fno-tree-pta
There was a problem hiding this comment.
Oh I see -- that was already present for gnu. So adding this flag for GNU is not new, it's just we didn't have a gnugpu Depends file yet and therefore builds with gnugpu might also need that. I can redo PR to exclude adding those flags.
There was a problem hiding this comment.
SO you think I should remove the flags to set -fno-tree-pta?
There was a problem hiding this comment.
No, just document that you are adding the flag in this PR
There was a problem hiding this comment.
Something like
* Add -fallow-argument-mismatch for all GNU builds (including gnugpu).
* Only add -fallow-invalid-boz for 2 specific files for gnu/gnugpu builds.
* Also adding the -fno-tree-pta flag to some MPAS CICE sources (required for gcc 9.0+)
This PR adds Depends.gnugpu.cmake which is similar to Depends.gnu.cmake
[BFB]
There was a problem hiding this comment.
But the -fno-tree-pta flag is already there for all GNU buiilds.
This PR also includes it for gnugpu.
I thought my comment "adds Depends.gnugpu.cmake which is similar to Depends.gnu.cmake" would indicate.
Add flags for GNU builds to allow using GNU v10 and higher versions Add -fallow-argument-mismatch for all GNU builds (including gnugpu). Only add -fallow-invalid-boz for 2 specific files for gnu/gnugpu builds. This PR adds Depends.gnugpu.cmake which is similar to Depends.gnu.cmake Fixes #3954 And is needed first for #4809 and #4818 [BFB]
|
merged to next |
#4818) For Perlmutter, updating versions of modules to default. For the GNU compiler version, update to 10 (though current default is now 11). Note that updating to gnu v10 requires #4822 (already merged) (Specifically, adding -fallow-argument-mismatch -fallow-invalid-boz) Also removed the soft limit for stacksize for PM. Fixes: #4811
Add -fallow-argument-mismatch for all GNU builds (including gnugpu).
Only add -fallow-invalid-boz for 2 specific files for gnu/gnugpu builds.
This PR adds Depends.gnugpu.cmake which is similar to Depends.gnu.cmake
Fixes #3954
And is needed first for #4809 and #4818
[BFB]