-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GNU compiler flags to help build with GNU v10 and above #4817
Conversation
Specifically, adding -fallow-argument-mismatch -fallow-invalid-boz
@@ -40,6 +40,9 @@ endif() | |||
if (NOT DEBUG) | |||
string(APPEND FFLAGS " -O") | |||
endif() | |||
if (CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10) | |||
string(APPEND FFLAGS " -fallow-argument-mismatch -fallow-invalid-boz") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also found that we needed the "-fallow-argument-mismatch" flag for building SCORPIO with gnu 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect you need it for GNU v10 as well
Note it seems like these are work-around flags and there may be other ways to address. Or... we could only compile certain files (or components) with these flags. The
The Which looks to be used to init a hash before adding values. Not familiar with algorithm there, but perhaps there is way to change the code instead of using that flag. I'm testing with adding something for those 2 files in Depends.gnu* |
Are the changes BFB (BFB flag is missing in the PR desc, and the PR labels)? |
I added a commit to the branch to change how we issue the |
… Depends.gnu.cmake and add the logic to work-around a certain problem with ICE by removing a specific optimization via compiler flag.
Closing this in favor of #4822 |
Specifically, adding -fallow-argument-mismatch -fallow-invalid-boz for any GNU build using version 10 or higher.
Fixes #3954
[bfb]